Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes terminal on OS X and refuses subsequent input after prompting more than once (Node 8 only) #13647

Closed
adamreisnz opened this issue Jun 13, 2017 · 2 comments
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. macos Issues and PRs related to the macOS platform / OSX. readline Issues and PRs related to the built-in readline module.

Comments

@adamreisnz
Copy link

Version: 8.1.0
Platform: OS X, Darwin Kernel Version 15.5.0: Tue Apr 19 18:36:36 PDT 2016; root:xnu-3248.50.21~8/RELEASE_X86_64 x86_64

There's an issue in Node 8 with apps that ask the user for input. The first input works fine, but afterwards, with subsequent input requests, the user can't type anything into the terminal window anymore, and even CTRL-C is not responding, forcing you to close the window.

At first I thought the issue might be with the package prompt that I was using, so I switched to inquirer and found it was affected as well. When I then tried to create an isolated test case, I found that the issue affects npm init as well.

The first input works ok, but then when asked for the version, you can't press ENTER anymore and the terminal refuses any subsequent input:

image

When switching back to Node 7.10.0 it works as expected again, so it definitely seems like a core Node issue.

Happy to provide further information if needed, but it is fairly easy to reproduce with npm init.

@adamreisnz adamreisnz changed the title Crashes terminal and refuses subsequent input after prompting more than once Crashes terminal on OS X and refuses subsequent input after prompting more than once (Node 8 only) Jun 13, 2017
@mscdex mscdex added macos Issues and PRs related to the macOS platform / OSX. v8.x labels Jun 13, 2017
@mscdex
Copy link
Contributor

mscdex commented Jun 13, 2017

This will be fixed in the upcoming v8.1.1 release. Specifically, it is already fixed by #13560.

Duplicate of #13557

@mscdex mscdex added readline Issues and PRs related to the built-in readline module. duplicate Issues and PRs that are duplicates of other issues or PRs. labels Jun 13, 2017
@mscdex mscdex closed this as completed Jun 13, 2017
@adamreisnz
Copy link
Author

@mscdex thank you, I tried to search for an existing issue but couldn't find one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. macos Issues and PRs related to the macOS platform / OSX. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Development

No branches or pull requests

2 participants