Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog links to incorrect GH ticket #19516

Closed
oliversalzburg opened this issue Mar 21, 2018 · 3 comments
Closed

Changelog links to incorrect GH ticket #19516

oliversalzburg opened this issue Mar 21, 2018 · 3 comments
Labels
question Issues that look for answers.

Comments

@oliversalzburg
Copy link
Contributor

Looking at https://nodejs.org/en/blog/release/v9.9.0/ it says:

Add getColorDepth function to determine if terminal supports colors. (Ruben Bridgewater) #17615

But #17615 seems unrelated to that change. Other links I checked seem fine.

@BridgeAR
Copy link
Member

It is related as the commit landed in that PR. It was necessary to add the function for the feature I actually wanted to get landed.

@BridgeAR BridgeAR added the question Issues that look for answers. label Mar 21, 2018
@BridgeAR
Copy link
Member

Some PRs have more than a single commit.

I am going to close this as I do not see any further actions out of it. If there is something still open for you, please let me know.

@oliversalzburg
Copy link
Contributor Author

I just assumed the changelog is automatically generated and that there is a possible problem with the generation. If you say everything is in order, then that's fine with me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Issues that look for answers.
Projects
None yet
Development

No branches or pull requests

2 participants