Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error docs for removed error codes, where code hasn't been released yet. #22496

Closed
SirR4T opened this issue Aug 24, 2018 · 1 comment
Closed

Update error docs for removed error codes, where code hasn't been released yet. #22496

SirR4T opened this issue Aug 24, 2018 · 1 comment

Comments

@SirR4T
Copy link
Contributor

SirR4T commented Aug 24, 2018

This is a doc only bug.

Errors ERR_INVALID_ARRAY_LENGTH and ERR_INVALID_DOMAIN_NAME have now been removed in 186857f and 564048d respectively, and we would need to update the doc/api/errors.md for the same once these two land on a release branch.

Alternatively, fix them in different PRs, with the same labels (dont-land or semver-major) as the PRs that remove these error codes.

See #22100 (comment) for more details.
@SirR4T SirR4T mentioned this issue Aug 24, 2018
Closed
27 tasks
@apapirovski
Copy link
Contributor

As far as I can tell this has been addressed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apapirovski @SirR4T