-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs-capacitor module broken by backwards compat code in fs.ReadStream.open #30110
Comments
I'll look into whether we can do the deprecation in manner that does not break this. |
@targos: Though we should probably also look into refactoring the module since deprecation means that it should be removed eventually. |
Would be a lot easier to refactor and fix post #29656 |
Opened mike-marcacci/fs-capacitor#14 to help the module fix streams usage. |
@targos: My PR which fixes this in fs-capacitor has been merged and a new release should be available soonish. Do we still want to do something in Node or can we close this? |
@ronag Thanks for fixing the module! I think we're good. |
#29061 broke the
fs-capacitor
module (used bygraphql-upload
to handle file uploads).I don't know if that module could be refactored to fix this but currently it overloads the
open
method (and still calls it internally) so this results in an infinite recursion: https://github.com/mike-marcacci/fs-capacitor/blob/51ce05dfa8bfa7d915447d700d36e422480c43e0/src/index.mjs#L70-L79Originally posted by @targos in #29061
@ronag @mcollina
The text was updated successfully, but these errors were encountered: