Benchmark CI run error: benchmark/_test-double-benchmarker

[rickyes]

Run command:

./node-master benchmark/compare.js --old ./node-master --new ./node-master -- http2

Refs: #33928 (comment)

• Test: http2
• Platform: macOS,Linux
• Console Output:

/Users/ricky/projj/github.com/rickyes/node/benchmark/_test-double-benchmarker.js:40
    client.on('error', (e) => { throw e; });
                                ^

Error: connect EADDRNOTAVAIL 127.0.0.1:12346 - Local (0.0.0.0:0)
    at internalConnect (net.js:905:16)
    at defaultTriggerAsyncIdScope (internal/async_hooks.js:416:12)
    at net.js:997:9
    at processTicksAndRejections (internal/process/task_queues.js:75:11) {
  errno: -49,
  code: 'EADDRNOTAVAIL',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 12346
}
Error: test-double-http2 failed with 1.
    at ChildProcess.<anonymous> (/Users/ricky/projj/github.com/rickyes/node/benchmark/_http-benchmarkers.js:238:16)
    at Object.onceWrapper (events.js:421:26)
    at ChildProcess.emit (events.js:314:20)
    at maybeClose (internal/child_process.js:1051:16)
    at Socket.<anonymous> (internal/child_process.js:442:11)
    at Socket.emit (events.js:314:20)
    at Pipe.<anonymous> (net.js:656:12)

• Build Links: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/627/console

[rickyes]

@jasnell @Trott I can't find a way to fix it. Any good suggestions?

[Trott]

Is something else running on port 12346 on your machine? If so, you can tell it to use a different port with the NODE_COMMON_PORT environment variable:

NODE_COMMON_PORT=8080 ./node-master benchmark/compare.js --old ./node-master --new ./node-master -- http2

Oops, I made a small-but-important error. In tests, it's NODE_COMMON_PORT but apparently in benchmarks, it's just PORT:

PORT=8080 ./node-master benchmark/compare.js --old ./node-master --new ./node-master -- http2

Note, that I haven't tested this but determined it from reading the code. Sorry if I'm wrong again!

[rickyes]

Is something else running on port 12346 on your machine? If so, you can tell it to use a different port with the NODE_COMMON_PORT environment variable:

NODE_COMMON_PORT=8080 ./node-master benchmark/compare.js --old ./node-master --new ./node-master -- http2

Oops, I made a small-but-important error. In tests, it's NODE_COMMON_PORT but apparently in benchmarks, it's just PORT:

PORT=8080 ./node-master benchmark/compare.js --old ./node-master --new ./node-master -- http2

Note, that I haven't tested this but determined it from reading the code. Sorry if I'm wrong again!

It may not be port usage, I don't have any other programs using port 12346 on my machine, it could be a connection overload error.

[rickyes]

It doesn't always happen, but the odds are good that it will.

[rickyes]

@addaleax @BridgeAR Any good direction, maybe because the number of threads exceeds the number of connections?

[Trott]

If benchmarking is being throttled by the OS, I'm not sure I have a great suggestion, but maybe someone on @nodejs/benchmarking or @mscdex might have an idea.

[rickyes]

ping again @mscdex @nodejs/benchmarking