Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Installer - Post-Install Screen #3694

Closed
tracker1 opened this issue Nov 6, 2015 · 4 comments
Closed

Windows Installer - Post-Install Screen #3694

tracker1 opened this issue Nov 6, 2015 · 4 comments
Labels
blocked PRs that are blocked by other issues or PRs. install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform.

Comments

@tracker1
Copy link

tracker1 commented Nov 6, 2015

I was thinking it might be a good idea to have a couple of things added to the Node installer in windows. Namely, links to software needed for binary modules requiring a compile in windows... namely the latest Visual Studio (Community or C++ Express) version, and the latest Python 2.x

I don't think that most people coming into node for the first time in Windows understand that those two packages/applications are actually needed for some modules in windows. It would be nice if a simple splash screen during, or at the end of install could clarify this, and have links to the respective sites for download.

Alternatively, if there were an option to actually download/install the latest python and a compatible open-source compiler in windows during the install, that might be preferred.

While there are a great number of modules that are JS-only, and some that have pre/post-install downloaders for pre-built binaries in windows, I think having install options for the environment might be a good idea.

@Fishrock123 Fishrock123 added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. labels Nov 6, 2015
@rvagg
Copy link
Member

rvagg commented Nov 14, 2015

I like the documentation idea @tracker1. Perhaps you could have a poke around in tools/msvs/msi/ to see if you can work out how this might be done? It uses the WiX Toolset. You can generate an .msi file by using vcbuild msi nosign if you have WiX and the other compiler tools installed. Let us know if you have any questions about how to move forward.

@kaylynb
Copy link

kaylynb commented Dec 2, 2015

I haven't used WiX before, but I took a look at the msi project, and figured out how to get messaging applied to the installer. There are some issues that need to be resolved, but it looks like it's possible to do if needed. Just cut a PR linked to this issue.

@Trott
Copy link
Member

Trott commented Jun 8, 2016

The PR is blocked so I'm going to label this blocked too, I guess... :-|

@Trott Trott added the blocked PRs that are blocked by other issues or PRs. label Jun 8, 2016
@Trott
Copy link
Member

Trott commented Jul 7, 2017

This issue has been inactive for sufficiently long that it seems like perhaps it should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.

@Trott Trott closed this as completed Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

5 participants