node:test test should be element of builtinModules

[loynoir]

Version

v18.15.0

Platform

archlinux

Subsystem

No response

What steps will reproduce the bug?

No response

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

$ node
> void await import('node:test')
> (await import('module')).builtinModules.includes('test')
true

What do you see instead?

$ node
> void await import('node:test')
> (await import('module')).builtinModules.includes('test')
false

Additional information

$ node
> (await import('is-builtin-module')).default('node:test')
false

https://github.com/sindresorhus/is-builtin-module/blob/2b22980d890cd656419106e2d2cca5696453bd7f/index.js#L2

https://github.com/sindresorhus/builtin-modules/blob/0d234f3ad3965c57d8cc5b9ca198c505fe032452/index.js#L2

[MoLow]

I am not sure this is a bug, since 893995d enforces node:test can only be imported with a schema.
@cjihrig would you expect builtinModules to contain node:test?

[loynoir]

My outdated thoughts

Emm, after node: protocol introduced, and node:X and X is now kind of different, does it make sense to add .builtinModuleIds, and deprecate .builtinModules?

.builtinModuleIds

• it is something like ["X", "node:X", "X/promises", "node:X/promises"]

• in ESM, it refers to AST level import statement importId

• in CJS, it refers to AST level require expression arg[0]

• Compared with .builtinModules which use concept module, a layer over raw AST concept, leads to different instinct between node dev and userland dev

---

Or, I thinks providing isBuiltinId(importId_or_requireId: string) would be very nice, which I think this should be something in node instead of userland.

https://nodejs.org/api/module.html#moduleisbuiltinmodulename

[loynoir]

Problem solved.

is-builtin-module should be deprecated, in favor of node native nodeModule.isBuiltin

> nodeModule.isBuiltin('node:test')
true

[cjihrig]

@MoLow yes, this is a dupe of #42785