Console output for passing tests with the test runner

[gibfahn]

• Version: master
• Subsystem: test

When debugging tests, it's really useful to have the console out and console error appear in the test output when the tests pass. I've looked through the options in tools/test.py and I haven't seen anything, perhaps something using the -v option (not sure what that does).

[Fishrock123]

Erm, why is this useful when the tests pass?

I'd rather not have more to look at in my already busy console (where I regularly build Node multiple timers every day).

[gibfahn]

I'd rather not have more to look at in my already busy console (where I regularly build Node multiple timers every day).

@Fishrock123 I'm not talking about setting it as the default, it'd go behind a flag (e.g. the -v option).

Erm, why is this useful when the tests pass?

When you're trying to debug a flaky test using lots of console.log statements, to compare the console output for passing and failing versions, you need the console output for passing versions. I absolutely don't want this by default, but at the moment the only way to see console output for a (temporarily) passing test is to pass the --expect-fail tag.

I often see tests which pass when run normally but fail with the test runner, or pass when run once but fail 1 in 100 times. Timing issues usually don't show up in the debugger.

Also is there a reason you removed the feature request label? Did I use it wrong?

[Fishrock123]

@gibfahn this is about internal tooling, not worthy of the same label we use for public API requests IMO.

[gibfahn]

@Fishrock123 Ahh okay, fair enough.

Do you still have an issue with adding this if it's behind a flag?

[cjihrig]

Before we add any flag, I think we (the project) should come to some consensus on console.log() statements that are unrelated to the test outcome.

[gibfahn]

@cjihrig That's somewhat related, and I think we should definitely come to an agreement, but the reason I want this flag is for debugging tests, not for console output I'd commit back into node, so I'm not sure this issue depends on that.

[gibfahn]

Opened #9314 to cover inclusion of console.log in tests.

[Trott]

Should this remain open?

[gibfahn]

Should this remain open?

No, the feature request is covered in #9314