From c6cda5f2f5ba3e4b79d472186cb18cd155880a13 Mon Sep 17 00:00:00 2001 From: Vse Mozhet Byt Date: Sun, 28 May 2017 18:43:02 +0300 Subject: [PATCH 1/3] doc: update outputs of code examples in url.md --- doc/api/url.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/doc/api/url.md b/doc/api/url.md index 7f2cc97b75e986..333edd30a84604 100644 --- a/doc/api/url.md +++ b/doc/api/url.md @@ -287,7 +287,7 @@ console.log(myURL.toString()); // Prints https://a:b@xn--6qqa088eba/?abc#foo console.log(url.format(myURL, {fragment: false, unicode: true, auth: false})); - // Prints 'https://你好你好?abc' + // Prints 'https://你好你好/?abc' ``` *Note*: This variation of the `url.format()` method is currently considered to @@ -663,7 +663,7 @@ console.log(myURL.protocol); myURL.protocol = 'ftp'; console.log(myURL.href); - // Prints ftp://example.org + // Prints ftp://example.org/ ``` Invalid URL protocol values assigned to the `protocol` property are ignored. @@ -711,7 +711,7 @@ console.log(myURL.username); myURL.username = '123'; console.log(myURL.href); - // Prints https://123:xyz@example.com + // Prints https://123:xyz@example.com/ ``` Any invalid URL characters appearing in the value assigned the `username` @@ -846,7 +846,7 @@ const params = new URLSearchParams({ query: ['first', 'second'] }); console.log(params.getAll('query')); - // Prints ['first,second'] + // Prints [ 'first,second' ] console.log(params.toString()); // Prints 'user=abc&query=first%2Csecond' ``` @@ -902,7 +902,8 @@ console.log(params.toString()); new URLSearchParams([ ['user', 'abc', 'error'] ]); - // Throws TypeError: Each query pair must be a name/value tuple + // Throws TypeError [ERR_INVALID_TUPLE]: + // Each query pair must be an iterable [name, value] tuple ``` #### urlSearchParams.append(name, value) From 15ce0a5697e41768d4e3455d967620e4714c1114 Mon Sep 17 00:00:00 2001 From: Vse Mozhet Byt Date: Sun, 28 May 2017 18:45:06 +0300 Subject: [PATCH 2/3] doc: refine spaces in code examples of url.md --- doc/api/url.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/url.md b/doc/api/url.md index 333edd30a84604..a0abd4752ea71a 100644 --- a/doc/api/url.md +++ b/doc/api/url.md @@ -286,7 +286,7 @@ console.log(myURL.href); console.log(myURL.toString()); // Prints https://a:b@xn--6qqa088eba/?abc#foo -console.log(url.format(myURL, {fragment: false, unicode: true, auth: false})); +console.log(url.format(myURL, { fragment: false, unicode: true, auth: false })); // Prints 'https://你好你好/?abc' ``` @@ -432,7 +432,7 @@ that an effort will be made to coerce the given values into strings. For instance: ```js -const myURL = new URL({toString: () => 'https://example.org/'}); +const myURL = new URL({ toString: () => 'https://example.org/' }); // https://example.org/ ``` From 5a96f6b5063e088a791ffd34de6388b8fc85f722 Mon Sep 17 00:00:00 2001 From: Vse Mozhet Byt Date: Sun, 28 May 2017 18:47:19 +0300 Subject: [PATCH 3/3] doc: restore missing part in example of url.md --- doc/api/url.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/api/url.md b/doc/api/url.md index a0abd4752ea71a..101ed83e91c8a0 100644 --- a/doc/api/url.md +++ b/doc/api/url.md @@ -517,6 +517,7 @@ console.log(myURL.href); // Prints https://example.org/foo myURL.href = 'https://example.com/bar'; +console.log(myURL.href); // Prints https://example.com/bar ```