From 62dc9f0a7e8a8f3296aaf8258ffcdca3eaa9f7eb Mon Sep 17 00:00:00 2001 From: Bang Wu Date: Sun, 16 Jul 2017 15:18:05 +0800 Subject: [PATCH 1/2] change the typeerror to a regular expression --- test/parallel/test-stream-writable-null.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-stream-writable-null.js b/test/parallel/test-stream-writable-null.js index 438f250a17dde6..e246e5b28b804c 100644 --- a/test/parallel/test-stream-writable-null.js +++ b/test/parallel/test-stream-writable-null.js @@ -32,7 +32,7 @@ assert.doesNotThrow(() => { assert.throws(() => { const m = new MyWritable(); m.write(false, (err) => assert.ok(err)); -}, TypeError, 'Invalid non-string/buffer chunk'); +}, /^TypeError: Invalid non-string\/buffer chunk$/, 'Invalid non-string/buffer chunk'); assert.doesNotThrow(() => { const m = new MyWritable().on('error', (e) => { assert.ok(e); From 2fdd30c75a252013e5fec9fd0d93cd3ed5559499 Mon Sep 17 00:00:00 2001 From: Bang Wu Date: Sun, 16 Jul 2017 15:28:15 +0800 Subject: [PATCH 2/2] remove the unused third parameters --- test/parallel/test-stream-writable-null.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-stream-writable-null.js b/test/parallel/test-stream-writable-null.js index e246e5b28b804c..b6c62727f6c946 100644 --- a/test/parallel/test-stream-writable-null.js +++ b/test/parallel/test-stream-writable-null.js @@ -32,7 +32,7 @@ assert.doesNotThrow(() => { assert.throws(() => { const m = new MyWritable(); m.write(false, (err) => assert.ok(err)); -}, /^TypeError: Invalid non-string\/buffer chunk$/, 'Invalid non-string/buffer chunk'); +}, /^TypeError: Invalid non-string\/buffer chunk$/); assert.doesNotThrow(() => { const m = new MyWritable().on('error', (e) => { assert.ok(e);