From 73dd304e7299c54577cc5e51fbee3531dba6585a Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 2 Aug 2017 02:19:27 +0200 Subject: [PATCH 1/2] src: use existing strings over creating new ones This is a very very minor change. --- src/tcp_wrap.cc | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/tcp_wrap.cc b/src/tcp_wrap.cc index 4967b407145c1c..4bee4b97097f40 100644 --- a/src/tcp_wrap.cc +++ b/src/tcp_wrap.cc @@ -77,13 +77,9 @@ void TCPWrap::Initialize(Local target, // Init properties t->InstanceTemplate()->Set(String::NewFromUtf8(env->isolate(), "reading"), Boolean::New(env->isolate(), false)); - t->InstanceTemplate()->Set(String::NewFromUtf8(env->isolate(), "owner"), - Null(env->isolate())); - t->InstanceTemplate()->Set(String::NewFromUtf8(env->isolate(), "onread"), - Null(env->isolate())); - t->InstanceTemplate()->Set(String::NewFromUtf8(env->isolate(), - "onconnection"), - Null(env->isolate())); + t->InstanceTemplate()->Set(env->owner_string(), Null(env->isolate())); + t->InstanceTemplate()->Set(env->onread_string(), Null(env->isolate())); + t->InstanceTemplate()->Set(env->onconnection_string(), Null(env->isolate())); env->SetProtoMethod(t, "getAsyncId", AsyncWrap::GetAsyncId); env->SetProtoMethod(t, "asyncReset", AsyncWrap::AsyncReset); From 3338951a240a65ae996e62bcca567b1248ac8cc1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tobias=20Nie=C3=9Fen?= Date: Wed, 2 Aug 2017 13:17:06 +0200 Subject: [PATCH 2/2] src: reuse 'ondone' string in node_crypto.cc --- src/node_crypto.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/node_crypto.cc b/src/node_crypto.cc index d03d8ad2f2ce8d..3d1b4887f11ae7 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -5666,9 +5666,7 @@ void RandomBytesBuffer(const FunctionCallbackInfo& args) { data, RandomBytesRequest::DONT_FREE_DATA); if (args[3]->IsFunction()) { - obj->Set(env->context(), - FIXED_ONE_BYTE_STRING(args.GetIsolate(), "ondone"), - args[3]).FromJust(); + obj->Set(env->context(), env->ondone_string(), args[3]).FromJust(); if (env->in_domain()) { obj->Set(env->context(),