From 982dd05471485720cf26015166bbbb0a8715c07b Mon Sep 17 00:00:00 2001 From: Nikolai Vavilov Date: Mon, 20 Nov 2017 16:56:33 +0200 Subject: [PATCH 1/2] doc: require CI status indicator in PRs Commits are often landed despite failing on one or more CI platforms. Having a CI status indicator in the PR should make this less likely to happen. --- COLLABORATOR_GUIDE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index d8d0651ff53ca4..96d57cd0f64081 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -142,6 +142,7 @@ test should *fail* before the change, and *pass* after the change. All pull requests that modify executable code should be subjected to continuous integration tests on the [project CI server](https://ci.nodejs.org/). +The pull request should have a CI status indicator. #### Useful CI Jobs From 1809931f674a080bac45c283722fdfa8b634ae24 Mon Sep 17 00:00:00 2001 From: Nikolai Vavilov Date: Mon, 20 Nov 2017 20:23:37 +0200 Subject: [PATCH 2/2] if possible --- COLLABORATOR_GUIDE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 96d57cd0f64081..70533fad858add 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -142,7 +142,7 @@ test should *fail* before the change, and *pass* after the change. All pull requests that modify executable code should be subjected to continuous integration tests on the [project CI server](https://ci.nodejs.org/). -The pull request should have a CI status indicator. +The pull request should have a CI status indicator if possible. #### Useful CI Jobs