From b18b300b1f6a9db83caef72adc631677559dda32 Mon Sep 17 00:00:00 2001 From: Sarath Govind K K Date: Mon, 19 Nov 2018 10:52:30 +0530 Subject: [PATCH 1/4] src: elevate namespaces for repeated entities --- src/inspector_js_api.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc index 8ec6603e5b4bc3..b0e5e8e607d408 100644 --- a/src/inspector_js_api.cc +++ b/src/inspector_js_api.cc @@ -11,6 +11,7 @@ namespace { using v8::Boolean; using v8::Context; +using v8::Environment; using v8::Function; using v8::FunctionCallbackInfo; using v8::FunctionTemplate; @@ -18,6 +19,7 @@ using v8::HandleScope; using v8::Isolate; using v8::Local; using v8::MaybeLocal; +using v8::Message; using v8::NewStringType; using v8::Object; using v8::String; @@ -224,9 +226,9 @@ static void RegisterAsyncHookWrapper(const FunctionCallbackInfo& args) { Environment* env = Environment::GetCurrent(args); CHECK(args[0]->IsFunction()); - v8::Local enable_function = args[0].As(); + Local enable_function = args[0].As(); CHECK(args[1]->IsFunction()); - v8::Local disable_function = args[1].As(); + Local disable_function = args[1].As(); env->inspector_agent()->RegisterAsyncHook(env->isolate(), enable_function, disable_function); } From b916604ef167c49bcc88acc8de62b8d1507c41fe Mon Sep 17 00:00:00 2001 From: Sarath Govind K K Date: Mon, 19 Nov 2018 11:15:51 +0530 Subject: [PATCH 2/4] fixup: remove unwanted changes --- src/inspector_js_api.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc index b0e5e8e607d408..688175ed205646 100644 --- a/src/inspector_js_api.cc +++ b/src/inspector_js_api.cc @@ -11,7 +11,6 @@ namespace { using v8::Boolean; using v8::Context; -using v8::Environment; using v8::Function; using v8::FunctionCallbackInfo; using v8::FunctionTemplate; From 9a5f109ffbd70c2653f0e088d65f6e0db45a28a9 Mon Sep 17 00:00:00 2001 From: Sarath Govind K K Date: Mon, 19 Nov 2018 11:17:48 +0530 Subject: [PATCH 3/4] fixup: remove unwanted v8::Message delcaration --- src/inspector_js_api.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc index 688175ed205646..87dd5b1b23caae 100644 --- a/src/inspector_js_api.cc +++ b/src/inspector_js_api.cc @@ -18,7 +18,6 @@ using v8::HandleScope; using v8::Isolate; using v8::Local; using v8::MaybeLocal; -using v8::Message; using v8::NewStringType; using v8::Object; using v8::String; From 2817ac0179792e94dfd41285240e82341ead7322 Mon Sep 17 00:00:00 2001 From: Sarath Govind K K Date: Mon, 19 Nov 2018 12:07:48 +0530 Subject: [PATCH 4/4] made changes in Local --- src/inspector_js_api.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc index 87dd5b1b23caae..52f14639a430d3 100644 --- a/src/inspector_js_api.cc +++ b/src/inspector_js_api.cc @@ -224,7 +224,7 @@ static void RegisterAsyncHookWrapper(const FunctionCallbackInfo& args) { Environment* env = Environment::GetCurrent(args); CHECK(args[0]->IsFunction()); - Local enable_function = args[0].As(); + Local enable_function = args[0].As(); CHECK(args[1]->IsFunction()); Local disable_function = args[1].As(); env->inspector_agent()->RegisterAsyncHook(env->isolate(),