From 9db48578b6d22f4b83cf022ce4d63602f1a19cde Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Thu, 27 Jun 2019 14:46:09 +0200 Subject: [PATCH 1/3] build: remove --code-cache-path help option This commit removes the now obsolete option. --- configure.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/configure.py b/configure.py index 4985200b284bae..2c19e97f35f61b 100755 --- a/configure.py +++ b/configure.py @@ -515,11 +515,6 @@ dest='without_siphash', help=optparse.SUPPRESS_HELP) -parser.add_option('--code-cache-path', - action='store', - dest='code_cache_path', - help='optparse.SUPPRESS_HELP') - # End dummy list. parser.add_option('--without-ssl', From 5dfb434c897b6e090cb8e1ead6849aa11d474e39 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Tue, 2 Jul 2019 07:45:06 +0200 Subject: [PATCH 2/3] build: rename node_code_cache_path to node_code_cache This commit renames node_code_cache_path and removes the path from as it does not really describe the configuration property as a path anymore. Instead it indicates whether the code cache is used or not. --- configure.py | 2 +- test/parallel/test-code-cache.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.py b/configure.py index 2c19e97f35f61b..3bd64622153170 100755 --- a/configure.py +++ b/configure.py @@ -1111,7 +1111,7 @@ def configure_node(o): o['variables']['node_no_browser_globals'] = b(options.no_browser_globals) # TODO(refack): fix this when implementing embedded code-cache when cross-compiling. if o['variables']['want_separate_host_toolset'] == 0: - o['variables']['node_code_cache_path'] = 'yes' + o['variables']['node_code_cache'] = 'yes' o['variables']['node_shared'] = b(options.shared) node_module_version = getmoduleversion.get_version() diff --git a/test/parallel/test-code-cache.js b/test/parallel/test-code-cache.js index 626fbfb518e3be..d01392f1ee6433 100644 --- a/test/parallel/test-code-cache.js +++ b/test/parallel/test-code-cache.js @@ -47,7 +47,7 @@ if (!process.features.cached_builtins) { } } else { // Native compiled assert.strictEqual( - process.config.variables.node_code_cache_path, + process.config.variables.node_code_cache, 'yes' ); From f57b8a6b0438d1f5aaff62e9e04ca6a5135edd24 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Thu, 4 Jul 2019 07:01:06 +0200 Subject: [PATCH 3/3] squash:! add comment --- configure.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.py b/configure.py index 3bd64622153170..783661a4fa428d 100755 --- a/configure.py +++ b/configure.py @@ -1111,7 +1111,7 @@ def configure_node(o): o['variables']['node_no_browser_globals'] = b(options.no_browser_globals) # TODO(refack): fix this when implementing embedded code-cache when cross-compiling. if o['variables']['want_separate_host_toolset'] == 0: - o['variables']['node_code_cache'] = 'yes' + o['variables']['node_code_cache'] = 'yes' # For testing o['variables']['node_shared'] = b(options.shared) node_module_version = getmoduleversion.get_version()