From e1604a08fc9e17d83fbaee990300f4a5a66effe5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Jos=C3=A9=20Arboleda?= <soyjuanarbol@gmail.com>
Date: Sun, 8 Sep 2019 13:49:25 -0500
Subject: [PATCH 1/5] doc: add code example to inspector.url() method
---
doc/api/inspector.md | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/doc/api/inspector.md b/doc/api/inspector.md
index f82c53f5bc3f51..cdba34954c88ea 100644
--- a/doc/api/inspector.md
+++ b/doc/api/inspector.md
@@ -52,6 +52,21 @@ parameter usage.
Return the URL of the active inspector, or `undefined` if there is none.
+```js
+// Node process was called with --inspect flag
+require('inspector').url()
+'ws://127.0.0.1:9229/whatever'
+
+// Node process was called with --inspect=localhost:3000 flag
+require('inspector').url()
+'ws://localhost:3000/whatever'
+// ---^ host ---^ port
+
+// Node process was called without --inspect flag
+require('inspector').url()
+undefined
+```
+
## inspector.waitForDebugger()
<!-- YAML
added: v12.7.0
From 843d69fffff6915d48f95f49bfe695cc35903f99 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Jos=C3=A9=20Arboleda?= <soyjuanarbol@gmail.com>
Date: Sun, 8 Sep 2019 17:07:59 -0500
Subject: [PATCH 2/5] fixup
---
doc/api/inspector.md | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/doc/api/inspector.md b/doc/api/inspector.md
index cdba34954c88ea..024007d8f1e8ac 100644
--- a/doc/api/inspector.md
+++ b/doc/api/inspector.md
@@ -53,18 +53,17 @@ parameter usage.
Return the URL of the active inspector, or `undefined` if there is none.
```js
-// Node process was called with --inspect flag
+// Node.js process was called with --inspect flag.
require('inspector').url()
-'ws://127.0.0.1:9229/whatever'
+// 'ws://127.0.0.1:9229/whatever'
-// Node process was called with --inspect=localhost:3000 flag
+// Node.js process was called with --inspect=localhost:3000 flag.
require('inspector').url()
-'ws://localhost:3000/whatever'
-// ---^ host ---^ port
+// 'ws://localhost:3000/whatever'
-// Node process was called without --inspect flag
+// Node.js process was called without --inspect flag.
require('inspector').url()
-undefined
+// undefined
```
## inspector.waitForDebugger()
From 9c75d5a733419d584583b013ee2bb867a57276e1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Jos=C3=A9=20Arboleda?= <soyjuanarbol@gmail.com>
Date: Mon, 9 Sep 2019 18:41:28 -0500
Subject: [PATCH 3/5] fixup
---
doc/api/inspector.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/api/inspector.md b/doc/api/inspector.md
index 024007d8f1e8ac..a81a0bdd2cc091 100644
--- a/doc/api/inspector.md
+++ b/doc/api/inspector.md
@@ -55,11 +55,11 @@ Return the URL of the active inspector, or `undefined` if there is none.
```js
// Node.js process was called with --inspect flag.
require('inspector').url()
-// 'ws://127.0.0.1:9229/whatever'
+// 'ws://127.0.0.1:9229/7a8d85cf-a3db-43f0-b7dc-7fa3c13bf26d'
// Node.js process was called with --inspect=localhost:3000 flag.
require('inspector').url()
-// 'ws://localhost:3000/whatever'
+// 'ws://localhost:3000/7a8d85cf-a3db-43f0-b7dc-7fa3c13bf26d'
// Node.js process was called without --inspect flag.
require('inspector').url()
From b31502bd052fd1f50c8eda21574f786c1a0910f8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Jos=C3=A9=20Arboleda?= <soyjuanarbol@gmail.com>
Date: Fri, 27 Sep 2019 20:24:50 -0500
Subject: [PATCH 4/5] fixup
---
doc/api/inspector.md | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/doc/api/inspector.md b/doc/api/inspector.md
index a81a0bdd2cc091..af47e12f2e2458 100644
--- a/doc/api/inspector.md
+++ b/doc/api/inspector.md
@@ -52,18 +52,19 @@ parameter usage.
Return the URL of the active inspector, or `undefined` if there is none.
-```js
-// Node.js process was called with --inspect flag.
-require('inspector').url()
-// 'ws://127.0.0.1:9229/7a8d85cf-a3db-43f0-b7dc-7fa3c13bf26d'
-
-// Node.js process was called with --inspect=localhost:3000 flag.
-require('inspector').url()
-// 'ws://localhost:3000/7a8d85cf-a3db-43f0-b7dc-7fa3c13bf26d'
-
-// Node.js process was called without --inspect flag.
-require('inspector').url()
-// undefined
+```console
+$ node --inspect -p "require('inspector').url()"
+Debugger listening on ws://127.0.0.1:9229/166e272e-7a30-4d09-97ce-f1c012b43c34
+For help see https://nodejs.org/en/docs/inspector
+ws://127.0.0.1:9229/166e272e-7a30-4d09-97ce-f1c012b43c34
+
+$ node --inspect=localhost:3000 -p "require('inspector').url()"
+Debugger listening on ws://localhost:3000/51cf8d0e-3c36-4c59-8efd-54519839e56a
+For help see https://nodejs.org/en/docs/inspector
+ws://localhost:3000/51cf8d0e-3c36-4c59-8efd-54519839e56a
+
+$ node -p "require('inspector').url()"
+undefined
```
## inspector.waitForDebugger()
From f1aadae69a5b34d52051a5af92082b75fac86bba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Jos=C3=A9=20Arboleda?= <soyjuanarbol@gmail.com>
Date: Tue, 22 Oct 2019 14:15:05 -0500
Subject: [PATCH 5/5] fixup
---
doc/api/inspector.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/api/inspector.md b/doc/api/inspector.md
index af47e12f2e2458..af99f2c34645e5 100644
--- a/doc/api/inspector.md
+++ b/doc/api/inspector.md
@@ -53,17 +53,17 @@ parameter usage.
Return the URL of the active inspector, or `undefined` if there is none.
```console
-$ node --inspect -p "require('inspector').url()"
+$ node --inspect -p 'inspector.url()'
Debugger listening on ws://127.0.0.1:9229/166e272e-7a30-4d09-97ce-f1c012b43c34
For help see https://nodejs.org/en/docs/inspector
ws://127.0.0.1:9229/166e272e-7a30-4d09-97ce-f1c012b43c34
-$ node --inspect=localhost:3000 -p "require('inspector').url()"
+$ node --inspect=localhost:3000 -p 'inspector.url()'
Debugger listening on ws://localhost:3000/51cf8d0e-3c36-4c59-8efd-54519839e56a
For help see https://nodejs.org/en/docs/inspector
ws://localhost:3000/51cf8d0e-3c36-4c59-8efd-54519839e56a
-$ node -p "require('inspector').url()"
+$ node -p 'inspector.url()'
undefined
```