From efbf6bd8e28326cdeb94bacaeb8603bd64867621 Mon Sep 17 00:00:00 2001 From: Kirill Fomichev Date: Wed, 11 Sep 2019 21:49:39 +0300 Subject: [PATCH 1/2] perf_hooks: remove not exist entries from inspect Some of the milestones was removed in PR #21247 but entries not removed from function for inspect PerformanceNodeTiming. --- lib/perf_hooks.js | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lib/perf_hooks.js b/lib/perf_hooks.js index 12909b047ce20b..18b0332feaffaa 100644 --- a/lib/perf_hooks.js +++ b/lib/perf_hooks.js @@ -205,15 +205,7 @@ class PerformanceNodeTiming extends PerformanceEntry { bootstrapComplete: this.bootstrapComplete, environment: this.environment, loopStart: this.loopStart, - loopExit: this.loopExit, - thirdPartyMainStart: this.thirdPartyMainStart, - thirdPartyMainEnd: this.thirdPartyMainEnd, - clusterSetupStart: this.clusterSetupStart, - clusterSetupEnd: this.clusterSetupEnd, - moduleLoadStart: this.moduleLoadStart, - moduleLoadEnd: this.moduleLoadEnd, - preloadModuleLoadStart: this.preloadModuleLoadStart, - preloadModuleLoadEnd: this.preloadModuleLoadEnd + loopExit: this.loopExit }; } } From 7a01405375a0492da512c45b3dc58929aab0b4c5 Mon Sep 17 00:00:00 2001 From: Kirill Fomichev Date: Thu, 12 Sep 2019 08:32:56 +0300 Subject: [PATCH 2/2] perf_hooks: remove removed milestones from tests --- test/parallel/test-trace-events-bootstrap.js | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/test/parallel/test-trace-events-bootstrap.js b/test/parallel/test-trace-events-bootstrap.js index 087fbd2f182a61..7251a9824dc951 100644 --- a/test/parallel/test-trace-events-bootstrap.js +++ b/test/parallel/test-trace-events-bootstrap.js @@ -12,15 +12,7 @@ const names = [ 'v8Start', 'loopStart', 'loopExit', - 'bootstrapComplete', - 'thirdPartyMainStart', - 'thirdPartyMainEnd', - 'clusterSetupStart', - 'clusterSetupEnd', - 'moduleLoadStart', - 'moduleLoadEnd', - 'preloadModulesLoadStart', - 'preloadModulesLoadEnd' + 'bootstrapComplete' ]; if (process.argv[2] === 'child') {