From 0a2edb5dd407e5d83f55a934b5538852d36dc0e5 Mon Sep 17 00:00:00 2001 From: Benjamin Gruenbaum Date: Sun, 31 May 2020 15:57:40 +0300 Subject: [PATCH 1/2] events: deal with no arguments case --- lib/internal/event_target.js | 2 +- test/parallel/test-eventtarget.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js index 763542eb0fc2fa..b025509a2014ef 100644 --- a/lib/internal/event_target.js +++ b/lib/internal/event_target.js @@ -50,7 +50,7 @@ class Event { this.#cancelable = !!cancelable; this.#bubbles = !!bubbles; this.#composed = !!composed; - this.#type = String(type); + this.#type = '' + type; // isTrusted is special (LegacyUnforgeable) Object.defineProperty(this, 'isTrusted', { get() { return false; }, diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js index 99d717abda6e8d..1b79a6bbb0ffd6 100644 --- a/test/parallel/test-eventtarget.js +++ b/test/parallel/test-eventtarget.js @@ -49,6 +49,7 @@ ok(EventTarget); ev.preventDefault(); strictEqual(ev.defaultPrevented, true); + throws(() => new Event(Symbol()), TypeError); } { const ev = new Event('foo'); From 56f3b58ca90dca3f522db6f40805cf1c8600f74b Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Sun, 31 May 2020 15:45:46 +0200 Subject: [PATCH 2/2] fixup! Signed-off-by: Ruben Bridgewater --- lib/internal/event_target.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js index b025509a2014ef..611aa9922118a1 100644 --- a/lib/internal/event_target.js +++ b/lib/internal/event_target.js @@ -50,7 +50,7 @@ class Event { this.#cancelable = !!cancelable; this.#bubbles = !!bubbles; this.#composed = !!composed; - this.#type = '' + type; + this.#type = `${type}`; // isTrusted is special (LegacyUnforgeable) Object.defineProperty(this, 'isTrusted', { get() { return false; },