From 55302938a3a37e368e237c9642834781f61daf22 Mon Sep 17 00:00:00 2001 From: ZiJian Liu Date: Tue, 22 Dec 2020 20:55:11 +0800 Subject: [PATCH 1/2] test: increase coverage for diagnostics_channel 1. test subscribe with invalid args https://coverage.nodejs.org/coverage-21f2e8859dfbf09f/lib/diagnostics_channel.js.html#L27 2. test create channel with invalid args https://coverage.nodejs.org/coverage-21f2e8859dfbf09f/lib/diagnostics_channel.js.html#L98 --- .../test-diagnostics-channel-object-channel-pub-sub.js | 4 ++++ test/parallel/test-diagnostics-channel-symbol-named.js | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/test/parallel/test-diagnostics-channel-object-channel-pub-sub.js b/test/parallel/test-diagnostics-channel-object-channel-pub-sub.js index bae69b02415785..7660f1d666e640 100644 --- a/test/parallel/test-diagnostics-channel-object-channel-pub-sub.js +++ b/test/parallel/test-diagnostics-channel-object-channel-pub-sub.js @@ -37,3 +37,7 @@ channel.publish(input); // Should not publish after subscriber is unsubscribed channel.unsubscribe(subscriber); assert.ok(!channel.hasSubscribers); + +assert.throws(() => { + channel.subscribe(null); +}, /ERR_INVALID_ARG_TYPE/); diff --git a/test/parallel/test-diagnostics-channel-symbol-named.js b/test/parallel/test-diagnostics-channel-symbol-named.js index b98c2a1ef3ec6c..96fe0fa53596e2 100644 --- a/test/parallel/test-diagnostics-channel-symbol-named.js +++ b/test/parallel/test-diagnostics-channel-symbol-named.js @@ -20,3 +20,9 @@ channel.subscribe(common.mustCall((message, name) => { })); channel.publish(input); + +{ + assert.throws(() => { + dc.channel(null); + }, /ERR_INVALID_ARG_TYPE/); +} From 1a6c9861fad12cbbedef614bcc1c1c58b0c75e47 Mon Sep 17 00:00:00 2001 From: Lxxyx Date: Wed, 23 Dec 2020 19:29:49 +0800 Subject: [PATCH 2/2] Update test/parallel/test-diagnostics-channel-object-channel-pub-sub.js Co-authored-by: Luigi Pinca --- .../parallel/test-diagnostics-channel-object-channel-pub-sub.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-diagnostics-channel-object-channel-pub-sub.js b/test/parallel/test-diagnostics-channel-object-channel-pub-sub.js index 7660f1d666e640..cbc5b4d2e9a953 100644 --- a/test/parallel/test-diagnostics-channel-object-channel-pub-sub.js +++ b/test/parallel/test-diagnostics-channel-object-channel-pub-sub.js @@ -40,4 +40,4 @@ assert.ok(!channel.hasSubscribers); assert.throws(() => { channel.subscribe(null); -}, /ERR_INVALID_ARG_TYPE/); +}, { code: 'ERR_INVALID_ARG_TYPE' });