From a983ba9bb6f7ec208275ef637117e8ff003d2f97 Mon Sep 17 00:00:00 2001
From: James M Snell <jasnell@gmail.com>
Date: Tue, 6 Apr 2021 10:20:53 -0700
Subject: [PATCH 1/2] assert: change status of legacy asserts
Previously marked deprecated, but these are unlikely to ever see
breaking changes or complete removal. Mark as legacy instead.
Signed-off-by: James M Snell <jasnell@gmail.com>
---
doc/api/assert.md | 24 ++++++++++++++++++++----
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/doc/api/assert.md b/doc/api/assert.md
index 45693dd52b0324..2b508a073aeae3 100644
--- a/doc/api/assert.md
+++ b/doc/api/assert.md
@@ -455,6 +455,10 @@ An alias of [`assert.ok()`][].
<!-- YAML
added: v0.1.21
changes:
+ - version: REPLACEME
+ pr-url: https://github.com/nodejs/node/pull/00000
+ description: In Legacy assertion mode, changed status from Deprecated to
+ Legacy.
- version: v14.0.0
pr-url: https://github.com/nodejs/node/pull/30766
description: NaN is now treated as being identical in case both sides are
@@ -496,7 +500,7 @@ An alias of [`assert.deepStrictEqual()`][].
**Legacy assertion mode**
-> Stability: 0 - Deprecated: Use [`assert.deepStrictEqual()`][] instead.
+> Stability: 3 - Legacy: Use [`assert.deepStrictEqual()`][] instead.
Tests for deep equality between the `actual` and `expected` parameters. Consider
using [`assert.deepStrictEqual()`][] instead. [`assert.deepEqual()`][] can have
@@ -1123,6 +1127,10 @@ assert.doesNotThrow(
<!-- YAML
added: v0.1.21
changes:
+ - version: REPLACEME
+ pr-url: https://github.com/nodejs/node/pull/00000
+ description: In Legacy assertion mode, changed status from Deprecated to
+ Legacy.
- version: v14.0.0
pr-url: https://github.com/nodejs/node/pull/30766
description: NaN is now treated as being identical in case both sides are
@@ -1139,7 +1147,7 @@ An alias of [`assert.strictEqual()`][].
**Legacy assertion mode**
-> Stability: 0 - Deprecated: Use [`assert.strictEqual()`][] instead.
+> Stability: 3 - Legacy: Use [`assert.strictEqual()`][] instead.
Tests shallow, coercive equality between the `actual` and `expected` parameters
using the [Abstract Equality Comparison][] ( `==` ). `NaN` is special handled
@@ -1448,6 +1456,10 @@ instance of an [`Error`][] then it will be thrown instead of the
<!-- YAML
added: v0.1.21
changes:
+ - version: REPLACEME
+ pr-url: https://github.com/nodejs/node/pull/00000
+ description: In Legacy assertion mode, changed status from Deprecated to
+ Legacy.
- version: v14.0.0
pr-url: https://github.com/nodejs/node/pull/30766
description: NaN is now treated as being identical in case both sides are
@@ -1485,7 +1497,7 @@ An alias of [`assert.notDeepStrictEqual()`][].
**Legacy assertion mode**
-> Stability: 0 - Deprecated: Use [`assert.notDeepStrictEqual()`][] instead.
+> Stability: 3 - Legacy: Use [`assert.notDeepStrictEqual()`][] instead.
Tests for any deep inequality. Opposite of [`assert.deepEqual()`][].
@@ -1624,6 +1636,10 @@ instead of the [`AssertionError`][].
<!-- YAML
added: v0.1.21
changes:
+ - version: REPLACEME
+ pr-url: https://github.com/nodejs/node/pull/00000
+ description: In Legacy assertion mode, changed status from Deprecated to
+ Legacy.
- version: v14.0.0
pr-url: https://github.com/nodejs/node/pull/30766
description: NaN is now treated as being identical in case both sides are
@@ -1640,7 +1656,7 @@ An alias of [`assert.notStrictEqual()`][].
**Legacy assertion mode**
-> Stability: 0 - Deprecated: Use [`assert.notStrictEqual()`][] instead.
+> Stability: 3 - Legacy: Use [`assert.notStrictEqual()`][] instead.
Tests shallow, coercive inequality with the [Abstract Equality Comparison][]
(`!=` ). `NaN` is special handled and treated as being identical in case both
From bb343e53f3111020e7e8bbe38a92285c6023e062 Mon Sep 17 00:00:00 2001
From: James M Snell <jasnell@gmail.com>
Date: Tue, 6 Apr 2021 11:11:07 -0700
Subject: [PATCH 2/2] [Squash] fixup
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
---
doc/api/assert.md | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/api/assert.md b/doc/api/assert.md
index 2b508a073aeae3..7735fe4140aa08 100644
--- a/doc/api/assert.md
+++ b/doc/api/assert.md
@@ -456,7 +456,7 @@ An alias of [`assert.ok()`][].
added: v0.1.21
changes:
- version: REPLACEME
- pr-url: https://github.com/nodejs/node/pull/00000
+ pr-url: https://github.com/nodejs/node/pull/38113
description: In Legacy assertion mode, changed status from Deprecated to
Legacy.
- version: v14.0.0
@@ -1128,7 +1128,7 @@ assert.doesNotThrow(
added: v0.1.21
changes:
- version: REPLACEME
- pr-url: https://github.com/nodejs/node/pull/00000
+ pr-url: https://github.com/nodejs/node/pull/38113
description: In Legacy assertion mode, changed status from Deprecated to
Legacy.
- version: v14.0.0
@@ -1457,7 +1457,7 @@ instance of an [`Error`][] then it will be thrown instead of the
added: v0.1.21
changes:
- version: REPLACEME
- pr-url: https://github.com/nodejs/node/pull/00000
+ pr-url: https://github.com/nodejs/node/pull/38113
description: In Legacy assertion mode, changed status from Deprecated to
Legacy.
- version: v14.0.0
@@ -1637,7 +1637,7 @@ instead of the [`AssertionError`][].
added: v0.1.21
changes:
- version: REPLACEME
- pr-url: https://github.com/nodejs/node/pull/00000
+ pr-url: https://github.com/nodejs/node/pull/38113
description: In Legacy assertion mode, changed status from Deprecated to
Legacy.
- version: v14.0.0