From 5c1eb781cf4a36f12e172c4922f87304273795c0 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 30 May 2022 15:27:55 -0400 Subject: [PATCH 01/21] doc: add initial doc on how to update cjs-module-lexer Add some initial doc based on discussion with Guy Bedford. Signed-off-by: Michael Dawson --- .../maintaining-cjs-module-lexer.md | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 doc/contributing/maintaining-cjs-module-lexer.md diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md new file mode 100644 index 00000000000000..20f4f8eb50dc61 --- /dev/null +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -0,0 +1,50 @@ +# Maintaining cjs-module-lexer + +The [cjs-module-lexer](https://github.com/nodejs/node/tree/master/deps/cjs-module-lexer) +dependency is used within the Node.js ESM implementation to detect the +named exports of a CommonJS module. + +It is used within +[.../lib/internal/modules/translators](https://github.com/nodejs/node/blob/master/lib/internal/modules/esm/translators.js) +in which both `internal/deps/cjs-module-lexer/lexer.js` and +\`internal/deps/cys-module-lexer/dist/lexer.js' are required and used. + +`interanal/deps/cjs-module-lexer/lexer.js` +is a regular JavaScript implementation that is +used when WebAssembly is not available on a platform. +\`internal/deps/cys-module-lexer/dist/lexer.js' is a faster +implementation using WebAssembly +which is generated from a C based implementation. + +The two different versions of lexer.js are maintained in the +[nodejs/cjs-module-lexer](https://github.com/nodejs/cjs-module-lexer) project. + +In order to update the Node.js dependencies to use to a newer verion +of cjs-module-lexer, complete the following steps: + +* Clone [nodejs/cjs-module-lexer](https://github.com/nodejs/cjs-module-lexer) + and check out the version that you want Node.js to use. +* Follow the WASM build steps outlined in + [wasm-build-steps](https://github.com/nodejs/cjs-module-lexer#wasm-build-steps). + This will generate the WASM based dist/lexer.js file. +* Preserving the same directory structure, copy the following files over + to deps/cjs-module-lexer directory where you have checked out Node.js + +```text +├── CHANGELOG.md +├── dist +│   ├── lexer.js +│   └── lexer.mjs +├── lexer.js +├── LICENSE +├── package.json +└── README.md +``` + +* Generate a PR, adding the files in the deps/cjs-module-lexer that + were modified. + +If updates are needed to cjs-module-lexer for Node.js, first PR +those updates into +[nodejs/cjs-module-lexer](https://github.com/nodejs/cjs-module-lexer), +request a release and then pull in the updated version once available. From 1f585a8f227c1f81459ca93e184991c213d6278e Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 30 May 2022 15:37:08 -0400 Subject: [PATCH 02/21] fixup --- doc/contributing/maintaining-cjs-module-lexer.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index 20f4f8eb50dc61..71ff5ec48bd502 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -7,12 +7,12 @@ named exports of a CommonJS module. It is used within [.../lib/internal/modules/translators](https://github.com/nodejs/node/blob/master/lib/internal/modules/esm/translators.js) in which both `internal/deps/cjs-module-lexer/lexer.js` and -\`internal/deps/cys-module-lexer/dist/lexer.js' are required and used. +\`internal/deps/cys-module-lexer/dist/lexer.js` are required and used. `interanal/deps/cjs-module-lexer/lexer.js` is a regular JavaScript implementation that is used when WebAssembly is not available on a platform. -\`internal/deps/cys-module-lexer/dist/lexer.js' is a faster +\`internal/deps/cys-module-lexer/dist/lexer.js` is a faster implementation using WebAssembly which is generated from a C based implementation. From a64872fadff82ddf14d1fe0945d49a4a20957d2d Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 30 May 2022 16:28:32 -0400 Subject: [PATCH 03/21] squash: address comments Signed-off-by: Michael Dawson --- doc/contributing/maintaining-cjs-module-lexer.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index 71ff5ec48bd502..1058e9faaa58a4 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -7,12 +7,12 @@ named exports of a CommonJS module. It is used within [.../lib/internal/modules/translators](https://github.com/nodejs/node/blob/master/lib/internal/modules/esm/translators.js) in which both `internal/deps/cjs-module-lexer/lexer.js` and -\`internal/deps/cys-module-lexer/dist/lexer.js` are required and used. +\`internal/deps/cys-module-lexer/dist/lexer.js\` are required and used. `interanal/deps/cjs-module-lexer/lexer.js` is a regular JavaScript implementation that is used when WebAssembly is not available on a platform. -\`internal/deps/cys-module-lexer/dist/lexer.js` is a faster +\`internal/deps/cys-module-lexer/dist/lexer.js\` is a faster implementation using WebAssembly which is generated from a C based implementation. @@ -41,6 +41,10 @@ of cjs-module-lexer, complete the following steps: └── README.md ``` +* Update the link to the cjs-module-lexer in the list at the end of + [doc/api/esm.md](https://github.com/nodejs/node/blob/master/doc/api/esm.md) + to point to the updated version. + * Generate a PR, adding the files in the deps/cjs-module-lexer that were modified. From 7fb464d92dd30646331a456f9a10fae596989ea9 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 31 May 2022 11:01:08 -0400 Subject: [PATCH 04/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Mohammed Keyvanzadeh --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index 1058e9faaa58a4..2e957462cde3ae 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -5,7 +5,7 @@ dependency is used within the Node.js ESM implementation to detect the named exports of a CommonJS module. It is used within -[.../lib/internal/modules/translators](https://github.com/nodejs/node/blob/master/lib/internal/modules/esm/translators.js) +[lib/internal/modules/esm/translators](https://github.com/nodejs/node/blob/master/lib/internal/modules/esm/translators.js) in which both `internal/deps/cjs-module-lexer/lexer.js` and \`internal/deps/cys-module-lexer/dist/lexer.js\` are required and used. From 5bb755cc187b4eb45fe2a1cbc7f0001f2a59c233 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 31 May 2022 11:01:14 -0400 Subject: [PATCH 05/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Mohammed Keyvanzadeh --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index 2e957462cde3ae..d267c044d1ddbf 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -12,7 +12,7 @@ in which both `internal/deps/cjs-module-lexer/lexer.js` and `interanal/deps/cjs-module-lexer/lexer.js` is a regular JavaScript implementation that is used when WebAssembly is not available on a platform. -\`internal/deps/cys-module-lexer/dist/lexer.js\` is a faster +\`internal/deps/cjs-module-lexer/dist/lexer.js\` is a faster implementation using WebAssembly which is generated from a C based implementation. From 5308a8f26d5f52ccfa89486e303cd7ac99398d83 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 31 May 2022 11:01:20 -0400 Subject: [PATCH 06/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Mohammed Keyvanzadeh --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index d267c044d1ddbf..eaf24cdfb02466 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -45,7 +45,7 @@ of cjs-module-lexer, complete the following steps: [doc/api/esm.md](https://github.com/nodejs/node/blob/master/doc/api/esm.md) to point to the updated version. -* Generate a PR, adding the files in the deps/cjs-module-lexer that +* Create a PR, adding the files in the deps/cjs-module-lexer that were modified. If updates are needed to cjs-module-lexer for Node.js, first PR From f8cb6f5918c5b3401a8b6731e88d5c59353ae788 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 31 May 2022 11:10:50 -0400 Subject: [PATCH 07/21] address comments --- doc/contributing/maintaining-cjs-module-lexer.md | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index eaf24cdfb02466..d758f91c7ab26c 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -7,14 +7,17 @@ named exports of a CommonJS module. It is used within [lib/internal/modules/esm/translators](https://github.com/nodejs/node/blob/master/lib/internal/modules/esm/translators.js) in which both `internal/deps/cjs-module-lexer/lexer.js` and -\`internal/deps/cys-module-lexer/dist/lexer.js\` are required and used. +`internal/deps/cys-module-lexer/dist/lexer.js` are required and used. `interanal/deps/cjs-module-lexer/lexer.js` is a regular JavaScript implementation that is used when WebAssembly is not available on a platform. -\`internal/deps/cjs-module-lexer/dist/lexer.js\` is a faster -implementation using WebAssembly -which is generated from a C based implementation. +`internal/deps/cjs-module-lexer/dist/lexer.js` is a faster +implementation using WebAssembly which is generated from a +C based implementation. These two paths +resolve to the files in `deps/cjs-module-lexer` due to their +inclusion in the `deps_files` entry in +[node.gyp](https://github.com/nodejs/node/blob/master/node.gyp). The two different versions of lexer.js are maintained in the [nodejs/cjs-module-lexer](https://github.com/nodejs/cjs-module-lexer) project. From 334ed03af0102585eff5d72216bd3f06cdbc3137 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 31 May 2022 11:12:19 -0400 Subject: [PATCH 08/21] fixup --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index d758f91c7ab26c..af449b7a8451c0 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -9,7 +9,7 @@ It is used within in which both `internal/deps/cjs-module-lexer/lexer.js` and `internal/deps/cys-module-lexer/dist/lexer.js` are required and used. -`interanal/deps/cjs-module-lexer/lexer.js` +`interaal/deps/cjs-module-lexer/lexer.js` is a regular JavaScript implementation that is used when WebAssembly is not available on a platform. `internal/deps/cjs-module-lexer/dist/lexer.js` is a faster From 55b4b1d439cfd9ef5c01ec12c04ab1f004bd0eea Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 31 May 2022 11:13:07 -0400 Subject: [PATCH 09/21] fixup --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index af449b7a8451c0..5ef8e52001186e 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -9,7 +9,7 @@ It is used within in which both `internal/deps/cjs-module-lexer/lexer.js` and `internal/deps/cys-module-lexer/dist/lexer.js` are required and used. -`interaal/deps/cjs-module-lexer/lexer.js` +`internal/deps/cjs-module-lexer/lexer.js` is a regular JavaScript implementation that is used when WebAssembly is not available on a platform. `internal/deps/cjs-module-lexer/dist/lexer.js` is a faster From 9dac62d12fad0e3ee39eab60546686549f28ec97 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 31 May 2022 11:18:10 -0400 Subject: [PATCH 10/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Mohammed Keyvanzadeh --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index 5ef8e52001186e..cfefbf6afa4d6f 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -7,7 +7,7 @@ named exports of a CommonJS module. It is used within [lib/internal/modules/esm/translators](https://github.com/nodejs/node/blob/master/lib/internal/modules/esm/translators.js) in which both `internal/deps/cjs-module-lexer/lexer.js` and -`internal/deps/cys-module-lexer/dist/lexer.js` are required and used. +`internal/deps/cjs-module-lexer/dist/lexer.js` are required and used. `internal/deps/cjs-module-lexer/lexer.js` is a regular JavaScript implementation that is From 277f5bb1ef3d0e8a579b819272f8905f4857ce42 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Wed, 1 Jun 2022 15:55:12 -0400 Subject: [PATCH 11/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Antoine du Hamel --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index cfefbf6afa4d6f..7233c84b2e3957 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -1,6 +1,6 @@ # Maintaining cjs-module-lexer -The [cjs-module-lexer](https://github.com/nodejs/node/tree/master/deps/cjs-module-lexer) +The [cjs-module-lexer](https://github.com/nodejs/node/tree/HEAD/deps/cjs-module-lexer) dependency is used within the Node.js ESM implementation to detect the named exports of a CommonJS module. From c9876b15ae104948786e3e88000001d37052140f Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Wed, 1 Jun 2022 15:55:18 -0400 Subject: [PATCH 12/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Antoine du Hamel --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index 7233c84b2e3957..1e2aa3ae5c577f 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -53,5 +53,5 @@ of cjs-module-lexer, complete the following steps: If updates are needed to cjs-module-lexer for Node.js, first PR those updates into -[nodejs/cjs-module-lexer](https://github.com/nodejs/cjs-module-lexer), +[nodejs/cjs-module-lexer][], request a release and then pull in the updated version once available. From bf1d2bec80c9c85070a198108dd23bc3cb9f49c6 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Wed, 1 Jun 2022 15:55:24 -0400 Subject: [PATCH 13/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Antoine du Hamel --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index 1e2aa3ae5c577f..b13e235f117f08 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -31,7 +31,7 @@ of cjs-module-lexer, complete the following steps: [wasm-build-steps](https://github.com/nodejs/cjs-module-lexer#wasm-build-steps). This will generate the WASM based dist/lexer.js file. * Preserving the same directory structure, copy the following files over - to deps/cjs-module-lexer directory where you have checked out Node.js + to `deps/cjs-module-lexer` directory where you have checked out Node.js. ```text ├── CHANGELOG.md From d27e41860e0f0f935260ad6615e85118ca47a1f6 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Wed, 1 Jun 2022 15:55:29 -0400 Subject: [PATCH 14/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Antoine du Hamel --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index b13e235f117f08..bdd25afa84da84 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -12,7 +12,7 @@ in which both `internal/deps/cjs-module-lexer/lexer.js` and `internal/deps/cjs-module-lexer/lexer.js` is a regular JavaScript implementation that is used when WebAssembly is not available on a platform. -`internal/deps/cjs-module-lexer/dist/lexer.js` is a faster +`internal/deps/cjs-module-lexer/dist/lexer` is a faster implementation using WebAssembly which is generated from a C based implementation. These two paths resolve to the files in `deps/cjs-module-lexer` due to their From fb2b273e8a311501bda87049ad1aa14dd6386c18 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Wed, 1 Jun 2022 15:55:34 -0400 Subject: [PATCH 15/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Antoine du Hamel --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index bdd25afa84da84..87766d193e6a49 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -9,7 +9,7 @@ It is used within in which both `internal/deps/cjs-module-lexer/lexer.js` and `internal/deps/cjs-module-lexer/dist/lexer.js` are required and used. -`internal/deps/cjs-module-lexer/lexer.js` +`internal/deps/cjs-module-lexer/lexer` is a regular JavaScript implementation that is used when WebAssembly is not available on a platform. `internal/deps/cjs-module-lexer/dist/lexer` is a faster From 3d91e2990b13c8178a86f3ad1f74564dc4da1e11 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Wed, 1 Jun 2022 15:55:40 -0400 Subject: [PATCH 16/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Antoine du Hamel --- doc/contributing/maintaining-cjs-module-lexer.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index 87766d193e6a49..61e3da4be47bc8 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -6,8 +6,8 @@ named exports of a CommonJS module. It is used within [lib/internal/modules/esm/translators](https://github.com/nodejs/node/blob/master/lib/internal/modules/esm/translators.js) -in which both `internal/deps/cjs-module-lexer/lexer.js` and -`internal/deps/cjs-module-lexer/dist/lexer.js` are required and used. +in which both `internal/deps/cjs-module-lexer/lexer` and +`internal/deps/cjs-module-lexer/dist/lexer` are required and used. `internal/deps/cjs-module-lexer/lexer` is a regular JavaScript implementation that is From b4ddcb857e3168a85eb5565e3d8ba7cd1200c373 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Wed, 1 Jun 2022 15:55:46 -0400 Subject: [PATCH 17/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Antoine du Hamel --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index 61e3da4be47bc8..67c84f08bd76f2 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -5,7 +5,7 @@ dependency is used within the Node.js ESM implementation to detect the named exports of a CommonJS module. It is used within -[lib/internal/modules/esm/translators](https://github.com/nodejs/node/blob/master/lib/internal/modules/esm/translators.js) +[`node:internal/modules/esm/translators`](https://github.com/nodejs/node/blob/HEAD/lib/internal/modules/esm/translators.js) in which both `internal/deps/cjs-module-lexer/lexer` and `internal/deps/cjs-module-lexer/dist/lexer` are required and used. From 7de0eae20989cd5939b960db478bcc6049c75635 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 13 Jun 2022 17:31:21 -0400 Subject: [PATCH 18/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Antoine du Hamel --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index 67c84f08bd76f2..730aa9fa75b37e 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -45,7 +45,7 @@ of cjs-module-lexer, complete the following steps: ``` * Update the link to the cjs-module-lexer in the list at the end of - [doc/api/esm.md](https://github.com/nodejs/node/blob/master/doc/api/esm.md) + [doc/api/esm.md](../api/esm.md) to point to the updated version. * Create a PR, adding the files in the deps/cjs-module-lexer that From 5a25b9d50521d2381dca92eaf9983112e7e6b796 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 13 Jun 2022 17:31:34 -0400 Subject: [PATCH 19/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Antoine du Hamel --- doc/contributing/maintaining-cjs-module-lexer.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index 730aa9fa75b37e..ddf3470d674f23 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -55,3 +55,5 @@ If updates are needed to cjs-module-lexer for Node.js, first PR those updates into [nodejs/cjs-module-lexer][], request a release and then pull in the updated version once available. + +[nodejs/cjs-module-lexer]: https://github.com/nodejs/cjs-module-lexer From 6d33ab2ec0ddd17513cc4c9b85bb41aedcf2e8d9 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 13 Jun 2022 17:31:43 -0400 Subject: [PATCH 20/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Antoine du Hamel --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index ddf3470d674f23..9ac5cdb01b29f5 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -20,7 +20,7 @@ inclusion in the `deps_files` entry in [node.gyp](https://github.com/nodejs/node/blob/master/node.gyp). The two different versions of lexer.js are maintained in the -[nodejs/cjs-module-lexer](https://github.com/nodejs/cjs-module-lexer) project. +[nodejs/cjs-module-lexer][] project. In order to update the Node.js dependencies to use to a newer verion of cjs-module-lexer, complete the following steps: From df2c15f36114dfdd39827bf392cbc71d827f8d8a Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 13 Jun 2022 17:31:48 -0400 Subject: [PATCH 21/21] Update doc/contributing/maintaining-cjs-module-lexer.md Co-authored-by: Antoine du Hamel --- doc/contributing/maintaining-cjs-module-lexer.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/maintaining-cjs-module-lexer.md b/doc/contributing/maintaining-cjs-module-lexer.md index 9ac5cdb01b29f5..d049702ed65ab7 100644 --- a/doc/contributing/maintaining-cjs-module-lexer.md +++ b/doc/contributing/maintaining-cjs-module-lexer.md @@ -25,7 +25,7 @@ The two different versions of lexer.js are maintained in the In order to update the Node.js dependencies to use to a newer verion of cjs-module-lexer, complete the following steps: -* Clone [nodejs/cjs-module-lexer](https://github.com/nodejs/cjs-module-lexer) +* Clone [nodejs/cjs-module-lexer][] and check out the version that you want Node.js to use. * Follow the WASM build steps outlined in [wasm-build-steps](https://github.com/nodejs/cjs-module-lexer#wasm-build-steps).