From 4e89ddbda5296dd6e206ead26d37f7a578998550 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Sat, 1 Apr 2023 05:56:52 +0200 Subject: [PATCH 1/3] test: move test-shadow-realm-gc.js to known_issues There is actually a leak. The test doesn't exercise the right path to create a substantial enough object graph (e.g. accessing something that results in the loading of a binding). This does something more complicated in the test and moves it to known_issues until we find a fix. --- test/{parallel => known_issues}/test-shadow-realm-gc.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) rename test/{parallel => known_issues}/test-shadow-realm-gc.js (73%) diff --git a/test/parallel/test-shadow-realm-gc.js b/test/known_issues/test-shadow-realm-gc.js similarity index 73% rename from test/parallel/test-shadow-realm-gc.js rename to test/known_issues/test-shadow-realm-gc.js index b640c6b8be3f1a..9ad2d22c4c8796 100644 --- a/test/parallel/test-shadow-realm-gc.js +++ b/test/known_issues/test-shadow-realm-gc.js @@ -8,5 +8,6 @@ require('../common'); for (let i = 0; i < 1000; i++) { - new ShadowRealm(); + const realm = new ShadowRealm(); + realm.evaluate(`new TextEncoder(); 1;`); } From 2b9c917f6593e08143199f78c77849d27b8efafa Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Mon, 3 Apr 2023 19:17:55 +0200 Subject: [PATCH 2/3] fixup! test: move test-shadow-realm-gc.js to known_issues --- test/known_issues/known_issues.status | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/known_issues/known_issues.status b/test/known_issues/known_issues.status index 7a50c10404c723..e19a87e7c39b6c 100644 --- a/test/known_issues/known_issues.status +++ b/test/known_issues/known_issues.status @@ -11,6 +11,9 @@ prefix known_issues # foreseeable future. The test itself is flaky and skipped. It # serves as a demonstration of the issue only. test-vm-timeout-escape-queuemicrotask: SKIP +# Skipping it because it crashes out of OOM instead of exiting. +# https://github.com/nodejs/node/issues/47353 +test-shadow-realm-gc: SKIP [$system==win32] From e0ea347ac230ab5933a382e8d7155153447eb92f Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Mon, 3 Apr 2023 20:54:44 +0200 Subject: [PATCH 3/3] fixup! test: move test-shadow-realm-gc.js to known_issues Co-authored-by: Chengzhong Wu --- test/known_issues/test-shadow-realm-gc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/known_issues/test-shadow-realm-gc.js b/test/known_issues/test-shadow-realm-gc.js index 9ad2d22c4c8796..cf15324e5cec06 100644 --- a/test/known_issues/test-shadow-realm-gc.js +++ b/test/known_issues/test-shadow-realm-gc.js @@ -9,5 +9,5 @@ require('../common'); for (let i = 0; i < 1000; i++) { const realm = new ShadowRealm(); - realm.evaluate(`new TextEncoder(); 1;`); + realm.evaluate('new TextEncoder(); 1;'); }