From baa5709ebbaa238c43b7fc49ae4f3e3ad7aeddc6 Mon Sep 17 00:00:00 2001 From: Carlos Espa Date: Tue, 23 Jul 2024 18:59:01 +0200 Subject: [PATCH 1/3] test: add test for one arg timers to increase coverage --- test/parallel/test-timers-args.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/parallel/test-timers-args.js b/test/parallel/test-timers-args.js index 1ba44d8bcf3664..9e427e0c172250 100644 --- a/test/parallel/test-timers-args.js +++ b/test/parallel/test-timers-args.js @@ -8,22 +8,22 @@ function range(n) { function timeout(nargs) { const args = range(nargs); - setTimeout.apply(null, [callback, 1].concat(args)); + setTimeout.apply(null, [callback].concat(args)); function callback() { - assert.deepStrictEqual([].slice.call(arguments), args); - if (nargs < 128) timeout(nargs + 1); + assert.deepStrictEqual([].slice.call(arguments), args.slice(1)); + if (nargs < 129) timeout(nargs + 1); } } function interval(nargs) { const args = range(nargs); - const timer = setTimeout.apply(null, [callback, 1].concat(args)); + const timer = setTimeout.apply(null, [callback].concat(args)); function callback() { clearInterval(timer); - assert.deepStrictEqual([].slice.call(arguments), args); - if (nargs < 128) interval(nargs + 1); + assert.deepStrictEqual([].slice.call(arguments), args.slice(1)); + if (nargs < 129) interval(nargs + 1); } } From 642b4cf7ac836639484a8fa2c9f9f2a56a5132c4 Mon Sep 17 00:00:00 2001 From: Carlos Espa Date: Tue, 23 Jul 2024 22:27:01 +0200 Subject: [PATCH 2/3] fixup! test: add test for one arg timers to increase coverage --- test/parallel/test-timers-args.js | 12 ++++++------ test/parallel/test-timers.js | 4 ++++ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/test/parallel/test-timers-args.js b/test/parallel/test-timers-args.js index 9e427e0c172250..1ba44d8bcf3664 100644 --- a/test/parallel/test-timers-args.js +++ b/test/parallel/test-timers-args.js @@ -8,22 +8,22 @@ function range(n) { function timeout(nargs) { const args = range(nargs); - setTimeout.apply(null, [callback].concat(args)); + setTimeout.apply(null, [callback, 1].concat(args)); function callback() { - assert.deepStrictEqual([].slice.call(arguments), args.slice(1)); - if (nargs < 129) timeout(nargs + 1); + assert.deepStrictEqual([].slice.call(arguments), args); + if (nargs < 128) timeout(nargs + 1); } } function interval(nargs) { const args = range(nargs); - const timer = setTimeout.apply(null, [callback].concat(args)); + const timer = setTimeout.apply(null, [callback, 1].concat(args)); function callback() { clearInterval(timer); - assert.deepStrictEqual([].slice.call(arguments), args.slice(1)); - if (nargs < 129) interval(nargs + 1); + assert.deepStrictEqual([].slice.call(arguments), args); + if (nargs < 128) interval(nargs + 1); } } diff --git a/test/parallel/test-timers.js b/test/parallel/test-timers.js index e04c1f3f184946..147c4cfd48fb47 100644 --- a/test/parallel/test-timers.js +++ b/test/parallel/test-timers.js @@ -79,3 +79,7 @@ setTimeout(common.mustCall(() => { // Test 10 ms timeout separately. setTimeout(common.mustCall(), 10); setInterval(common.mustCall(function() { clearInterval(this); }), 10); + +// Test no timeout separately +setTimeout(common.mustCall()); +setInterval(common.mustCall(function() { clearInterval(this); })); From ff11c2f7a0ceb233a2df2ee547dfb38641fbf3d5 Mon Sep 17 00:00:00 2001 From: Carlos Espa Date: Tue, 23 Jul 2024 23:05:32 +0200 Subject: [PATCH 3/3] fixup! fixup! test: add test for one arg timers to increase coverage --- test/parallel/test-timers.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/parallel/test-timers.js b/test/parallel/test-timers.js index 147c4cfd48fb47..11c6e106e85760 100644 --- a/test/parallel/test-timers.js +++ b/test/parallel/test-timers.js @@ -82,4 +82,5 @@ setInterval(common.mustCall(function() { clearInterval(this); }), 10); // Test no timeout separately setTimeout(common.mustCall()); +// eslint-disable-next-line no-restricted-syntax setInterval(common.mustCall(function() { clearInterval(this); }));