Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: layout shifts on dropdown #6937

Closed
Jay-Karia opened this issue Jul 20, 2024 · 2 comments
Closed

ui: layout shifts on dropdown #6937

Jay-Karia opened this issue Jul 20, 2024 · 2 comments

Comments

@Jay-Karia
Copy link
Contributor

URL:

https://nodejs.org/en/download/package-manager

Browser Name:

Chrome

Browser Version:

103.0.5060

Operating System:

Windows 10

How to reproduce the issue:

  1. Open downloads page (https://nodejs.org/en/download/package-manager)
  2. Click on the dropdown menu followed by "Install Node js"
    node issue dropdown

By clicking any one of the dropdowns, the layout of the website shifts due to a vertical scroll bar disappearing.
However, this issue does not occur on other tabs such as Prebuild InstallerPrebuilt Binaries, and Source Code (because they don't have a scrollbar!).)

@Jay-Karia Jay-Karia added the bug label Jul 20, 2024
@ovflowd
Copy link
Member

ovflowd commented Jul 20, 2024

This isn't a bug; we've been back and forth non-stop. People open PRs to fix said layout shift, then someone opens another PR to revert that, and the cat-and-mouse game continues.

At this point, I honestly don't see any advantage in either.

@ovflowd
Copy link
Member

ovflowd commented Jul 20, 2024

#6865 fixes the issue, I assume. Closing the issue!

@ovflowd ovflowd closed this as completed Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants