From ac1769f74006d176f9d60ce413fb5e44ba03b715 Mon Sep 17 00:00:00 2001 From: Bart Date: Sun, 13 Mar 2022 20:13:26 +0100 Subject: [PATCH 1/2] Remove call to deprecated function util.inherits --- .../guides/event-loop-timers-and-nexttick.md | 33 +++++++++---------- 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/locale/en/docs/guides/event-loop-timers-and-nexttick.md b/locale/en/docs/guides/event-loop-timers-and-nexttick.md index 54e6a4710f531..b75783b626233 100644 --- a/locale/en/docs/guides/event-loop-timers-and-nexttick.md +++ b/locale/en/docs/guides/event-loop-timers-and-nexttick.md @@ -444,19 +444,18 @@ the event loop to proceed, it must hit the **poll** phase, which means there is a non-zero chance that a connection could have been received allowing the connection event to be fired before the listening event. -Another example is running a function constructor that was to, say, -inherit from `EventEmitter` and it wanted to call an event within the -constructor: +Another example is inheriting from `EventEmitter` and emitting an +event from within the constructor: ```js const EventEmitter = require('events'); -const util = require('util'); -function MyEmitter() { - EventEmitter.call(this); - this.emit('event'); +class MyEmitter extends EventEmitter { + constructor() { + super(); + this.emit('event'); + } } -util.inherits(MyEmitter, EventEmitter); const myEmitter = new MyEmitter(); myEmitter.on('event', () => { @@ -472,17 +471,17 @@ after the constructor has finished, which provides the expected results: ```js const EventEmitter = require('events'); -const util = require('util'); - -function MyEmitter() { - EventEmitter.call(this); - // use nextTick to emit the event once a handler is assigned - process.nextTick(() => { - this.emit('event'); - }); +class MyEmitter extends EventEmitter { + constructor() { + super(); + + // use nextTick to emit the event once a handler is assigned + process.nextTick(() => { + this.emit('event'); + }); + } } -util.inherits(MyEmitter, EventEmitter); const myEmitter = new MyEmitter(); myEmitter.on('event', () => { From 700bb81ac58b1dcfe1bee04fcab8912b98462ad9 Mon Sep 17 00:00:00 2001 From: Bart Date: Sun, 13 Mar 2022 20:22:43 +0100 Subject: [PATCH 2/2] Update event-loop-timers-and-nexttick.md --- locale/en/docs/guides/event-loop-timers-and-nexttick.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/locale/en/docs/guides/event-loop-timers-and-nexttick.md b/locale/en/docs/guides/event-loop-timers-and-nexttick.md index b75783b626233..bc9986ce725f6 100644 --- a/locale/en/docs/guides/event-loop-timers-and-nexttick.md +++ b/locale/en/docs/guides/event-loop-timers-and-nexttick.md @@ -475,7 +475,7 @@ const EventEmitter = require('events'); class MyEmitter extends EventEmitter { constructor() { super(); - + // use nextTick to emit the event once a handler is assigned process.nextTick(() => { this.emit('event');