|
| 1 | +# Node.js Performance Team Meeting 2023-02-06 |
| 2 | + |
| 3 | +## Links |
| 4 | + |
| 5 | +* **Recording**: https://www.youtube.com/watch?v=l8-DCAMGobE |
| 6 | +* **GitHub Issue**: https://github.com/nodejs/performance/issues/48 |
| 7 | + |
| 8 | +## Present |
| 9 | + |
| 10 | +* Performance team: @nodejs/performance |
| 11 | +* Yagiz Nizipli: @anonrig |
| 12 | +* Marvin Hagemeister @marvinhagemeister |
| 13 | +* Ulises Gascon: @ulisesGascon |
| 14 | +* Stephen Belanger: @qard |
| 15 | +* Santiago Gimeno: @santigimeno |
| 16 | +* Tony Gorez: @tony-go |
| 17 | +* Rafael Gonzaga: @RafaelGSS |
| 18 | +* Robert Nagy: @ronag |
| 19 | + |
| 20 | + |
| 21 | +## Agenda |
| 22 | + |
| 23 | +## Announcements |
| 24 | + |
| 25 | +[Ada](https://github.com/ada-url/ada), the new URL parse will be added to Node.js as dependency in order to increase speed by 78 %, fetch will become faster too 🎉 |
| 26 | + |
| 27 | +Marvin released a really good blog post on https://marvinh.dev/blog/speeding-up-javascript-ecosystem-part-3/. |
| 28 | + |
| 29 | +*Extracted from **performance-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. |
| 30 | + |
| 31 | +### nodejs/node |
| 32 | + |
| 33 | +* Start time performance regression when upgrading from 16.x to 18.x [#45662](https://github.com/nodejs/node/issues/45662) |
| 34 | +19.x changes are already merged |
| 35 | +There is an ongoing work to port the changes to 16.x and 18.x (lead by @joyeecheung) |
| 36 | +This item will be removed from the agenda |
| 37 | +### nodejs/performance |
| 38 | + |
| 39 | +* AbortSignal is slow [#44](https://github.com/nodejs/performance/issues/44) |
| 40 | +Reached out to RxJS folks. There are some discussions and agreements ongoing, but after checking the performance improvements there were no major upgrades |
| 41 | +PR from Santigo (@santigimeno) improves the performance by 20% - https://github.com/nodejs/node/pull/46527 |
| 42 | +Ongoing discussion about further changes that could improve the performance even more include moving `Event.isTrusted` to the prototype and not setting `__proto__: null`. The former might break the spec. |
| 43 | +Recommendation escalate to WinterCG group |
| 44 | +* Node errors are very slow to create [#40](https://github.com/nodejs/performance/issues/40) |
| 45 | +This item will be removed from the agenda |
| 46 | +* Module resolution [#39](https://github.com/nodejs/performance/issues/39) |
| 47 | +There is an open PR relevant (pending from benchmark) |
| 48 | +Suggestion: Implement it fully in C++. Input value is a string, return value is a boolean, so this would lend itself to use v8 fast paths |
| 49 | +@tony-go will take a look at it |
| 50 | +We could expose it to user land later if we found a use case for it |
| 51 | +* fetch [#11](https://github.com/nodejs/performance/issues/11) |
| 52 | +We move from very slow to just slow in terms of performance |
| 53 | +There are more open opportunities, but let’s see how Ada will impact on the performance and then we can reevaluate the situation. |
| 54 | +This item will be removed from the agenda, and the issue will be closed. We can reopen the issue if needed. |
| 55 | +* WHATWG Streams [#9](https://github.com/nodejs/performance/issues/9) |
| 56 | +[Last update from Rafael](https://github.com/nodejs/performance/issues/9#issuecomment-1370136019) |
| 57 | +We will discuss it again in the next meeting |
| 58 | +* Buffer.(read|write)(U)Int(LE|BE)(8|16|32) [#2](https://github.com/nodejs/performance/issues/2) |
| 59 | +This item will be removed from the agenda |
| 60 | + |
| 61 | +* Reference to https://github.com/nodejs/performance/issues/51 |
| 62 | + |
| 63 | +## Q&A, Other |
| 64 | + |
| 65 | +## Upcoming Meetings |
| 66 | + |
| 67 | +* **Node.js Foundation Calendar**: https://nodejs.org/calendar |
| 68 | + |
| 69 | +Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. |
| 70 | + |
0 commit comments