quic: remove QuicStreamListener

This listener currently had the drawbacks of leaking memory
when an error is encountered and was otherwise equivalent to
the default listener.

PR-URL: #126
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: addaleax

src/node_quic_stream.cc

@@ -29,26 +29,6 @@ using v8::Value;
 
 namespace quic {
 
-uv_buf_t QuicStreamListener::OnStreamAlloc(size_t size) {
-  Environment* env = static_cast<QuicStream*>(stream_)->env();
-  return env->AllocateManaged(size).release();
-}
-
-void QuicStreamListener::OnStreamRead(ssize_t nread, const uv_buf_t& buf) {
-  QuicStream* stream = static_cast<QuicStream*>(stream_);
-  Environment* env = stream->env();
-  HandleScope handle_scope(env->isolate());
-  Context::Scope context_scope(env->context());
-
-  if (nread < 0) {
-    PassReadErrorToPreviousListener(nread);
-    return;
-  }
-
-  AllocatedBuffer buffer(stream->env(), buf);
-  stream->CallJSOnreadMethod(nread, buffer.ToArrayBuffer());
-}
-
 QuicStream::QuicStream(
     QuicSession* session,
     Local<Object> wrap,
@@ -82,7 +62,6 @@ QuicStream::QuicStream(
   session->AddStream(this);
   Debug(this, "Created");
   StreamBase::AttachToObject(GetObject());
-  PushStreamListener(&stream_listener_);
   stream_stats_.created_at = uv_hrtime();
 
   USE(wrap->DefineOwnProperty(

src/node_quic_stream.h

@@ -19,12 +19,6 @@ namespace quic {
 class QuicSession;
 class QuicServerSession;
 
-class QuicStreamListener : public StreamListener {
- public:
-  uv_buf_t OnStreamAlloc(size_t suggested_size) override;
-  void OnStreamRead(ssize_t nread, const uv_buf_t& buf) override;
-};
-
 // QuicStream's are simple data flows that, fortunately, do not
 // require much. They may be:
 //
@@ -356,7 +350,6 @@ class QuicStream : public AsyncWrap,
 
   inline void IncrementStats(size_t datalen);
 
-  QuicStreamListener stream_listener_;
   QuicSession* session_;
   int64_t stream_id_;
   uint64_t max_offset_;