Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.writable/.readable are not updated #123

Closed
mscdex opened this issue Mar 20, 2015 · 2 comments
Closed

.writable/.readable are not updated #123

mscdex opened this issue Mar 20, 2015 · 2 comments

Comments

@mscdex
Copy link
Contributor

mscdex commented Mar 20, 2015

Yes I know that these are supposedly "legacy" properties, but setting them to true and never updating them is a bug IMHO.

How else are we supposed to know if any stream has ended/finished without peering into the private _*ableState properties? For example, if you have a function that takes in a Readable stream. If the stream has already ended, it's not like you can attach an end event handler or anything.
@isaacs
Copy link
Contributor

isaacs commented Mar 21, 2015

I agree, if the fields are there, they may as well be updated when they change so that they're not lying.

Unless any others provide reasonable objections, patch welcome.

@mscdex
Copy link
Contributor Author

mscdex commented Mar 21, 2015

PR is at nodejs/node#1217

@mscdex mscdex closed this as completed Mar 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isaacs @mscdex