Skip to content

Commit 178a97c

Browse files
authored
fix: 🐛 add URL upstream variations in BalancedPool types (#1966)
🏁 Closes: #1948
1 parent b13312d commit 178a97c

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

test/types/balanced-pool.test-d.ts

+3
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ expectAssignable<BalancedPool>(new BalancedPool('', { factory: () => new Dispatc
1010
expectAssignable<BalancedPool>(new BalancedPool('', { factory: (origin, opts) => new Client(origin, opts) }))
1111
expectAssignable<BalancedPool>(new BalancedPool('', { connections: 1 }))
1212
expectAssignable<BalancedPool>(new BalancedPool(['http://localhost:4242', 'http://www.nodejs.org']))
13+
expectAssignable<BalancedPool>(new BalancedPool([new URL('http://localhost:4242'),new URL('http://www.nodejs.org')], {}))
1314

1415
{
1516
const pool = new BalancedPool('', {})
@@ -21,6 +22,8 @@ expectAssignable<BalancedPool>(new BalancedPool(['http://localhost:4242', 'http:
2122
// upstreams
2223
expectAssignable<BalancedPool>(pool.addUpstream('http://www.nodejs.org'))
2324
expectAssignable<BalancedPool>(pool.removeUpstream('http://www.nodejs.org'))
25+
expectAssignable<BalancedPool>(pool.addUpstream(new URL('http://www.nodejs.org')))
26+
expectAssignable<BalancedPool>(pool.removeUpstream(new URL('http://www.nodejs.org')))
2427
expectAssignable<string[]>(pool.upstreams)
2528

2629

types/balanced-pool.d.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ import { URL } from 'url'
55
export default BalancedPool
66

77
declare class BalancedPool extends Dispatcher {
8-
constructor(url: string | URL | string[], options?: Pool.Options);
8+
constructor(url: string | string[] | URL | URL[], options?: Pool.Options);
99

10-
addUpstream(upstream: string): BalancedPool;
11-
removeUpstream(upstream: string): BalancedPool;
10+
addUpstream(upstream: string | URL): BalancedPool;
11+
removeUpstream(upstream: string | URL): BalancedPool;
1212
upstreams: Array<string>;
1313

1414
/** `true` after `pool.close()` has been called. */

0 commit comments

Comments
 (0)