wasi: put wasi behind a flag

This commit puts the WASI implementation behind a
--experimental-wasi CLI flag, and prints an experimental
warning on first use of WASI. It also includes some
misc cleanup.

Author: cjihrig

doc/api/cli.md

@@ -207,6 +207,13 @@ added: v9.6.0
 
 Enable experimental ES Module support in the `vm` module.
 
+### `--experimental-wasi`
+<!-- YAML
+added: REPLACEME
+-->
+
+Enable experimental WebAssembly System Interface (WASI) support.
+
 ### `--experimental-wasm-modules`
 <!-- YAML
 added: v12.3.0
@@ -1006,6 +1013,7 @@ Node.js options that are allowed are:
 * `--experimental-repl-await`
 * `--experimental-report`
 * `--experimental-vm-modules`
+* `--experimental-wasi`
 * `--experimental-wasm-modules`
 * `--force-context-aware`
 * `--force-fips`

lib/internal/bootstrap/loaders.js

@@ -155,6 +155,9 @@ function NativeModule(id) {
   this.loaded = false;
   this.loading = false;
   this.canBeRequiredByUsers = !id.startsWith('internal/');
+
+  if (id === 'wasi')
+    this.canBeRequiredByUsers = !!internalBinding('config').experimentalWasi;
 }
 
 // To be called during pre-execution when --expose-internals is on.

lib/internal/modules/cjs/helpers.js

@@ -119,6 +119,11 @@ const builtinLibs = [
   'v8', 'vm', 'worker_threads', 'zlib'
 ];
 
+if (internalBinding('config').experimentalWasi) {
+  builtinLibs.push('wasi');
+  builtinLibs.sort();
+}
+
 if (typeof internalBinding('inspector').open === 'function') {
   builtinLibs.push('inspector');
   builtinLibs.sort();

lib/wasi.js

@@ -1,11 +1,13 @@
-// TODO(cjihrig): Put WASI behind a flag.
 'use strict';
 /* global WebAssembly */
 const { Array, ArrayPrototype, Object } = primordials;
 const { ERR_INVALID_ARG_TYPE } = require('internal/errors').codes;
+const { emitExperimentalWarning } = require('internal/util');
 const { WASI: _WASI } = internalBinding('wasi');
 const kSetMemory = Symbol('setMemory');
 
+emitExperimentalWarning('WASI');
+
 
 class WASI {
   constructor(options = {}) {

src/node_config.cc

@@ -84,6 +84,9 @@ static void Initialize(Local<Object> target,
 
   READONLY_PROPERTY(target, "hasCachedBuiltins",
      v8::Boolean::New(isolate, native_module::has_code_cache));
+
+  if (per_process::cli_options->per_isolate->per_env->experimental_wasi)
+    READONLY_TRUE_PROPERTY(target, "experimentalWasi");
 }  // InitConfig
 
 }  // namespace node

src/node_options.cc

@@ -369,6 +369,10 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
             &EnvironmentOptions::experimental_report,
             kAllowedInEnvironment);
 #endif  // NODE_REPORT
+  AddOption("--experimental-wasi",
+            "experimental WASI support",
+            &EnvironmentOptions::experimental_wasi,
+            kAllowedInEnvironment);
   AddOption("--expose-internals", "", &EnvironmentOptions::expose_internals);
   AddOption("--frozen-intrinsics",
             "experimental frozen intrinsics support",

src/node_options.h

@@ -150,6 +150,7 @@ class EnvironmentOptions : public Options {
 #ifdef NODE_REPORT
   bool experimental_report = false;
 #endif  //  NODE_REPORT
+  bool experimental_wasi = false;
   std::string eval_string;
   bool print_eval = false;
   bool force_repl = false;

src/node_wasi.cc

@@ -81,13 +81,12 @@ using v8::Value;
 WASI::WASI(Environment* env,
            Local<Object> object,
            uvwasi_options_t* options) : BaseObject(env, object) {
-  /* uvwasi_errno_t err = */ uvwasi_init(&uvw_, options);
+  CHECK_EQ(uvwasi_init(&uvw_, options), UVWASI_ESUCCESS);
   memory_.Reset();
 }
 
 
 WASI::~WASI() {
-  /* TODO(cjihrig): Free memory. */
   uvwasi_destroy(&uvw_);
 }
 

test/wasi/test-wasi-binding.js

@@ -1,3 +1,4 @@
+// Flags: --experimental-wasi
 'use strict';
 
 const common = require('../common');

test/wasi/test-wasi.js

@@ -1,11 +1,16 @@
 'use strict';
-require('../common');
+const common = require('../common');
 
 if (process.argv[2] === 'wasi-child') {
   const fixtures = require('../common/fixtures');
   const tmpdir = require('../../test/common/tmpdir');
   const fs = require('fs');
   const path = require('path');
+
+  common.expectWarning('ExperimentalWarning',
+                       'WASI is an experimental feature. This feature could ' +
+                       'change at any time');
+
   const { WASI } = require('wasi');
   tmpdir.refresh();
   const wasmDir = path.join(__dirname, 'wasm');
@@ -38,6 +43,7 @@ if (process.argv[2] === 'wasi-child') {
       opts.input = options.stdin;
 
     const child = cp.spawnSync(process.execPath, [
+      '--experimental-wasi',
       '--experimental-wasm-bigint',
       __filename,
       'wasi-child',