fix: add tags for instance profile #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you extend the tags to root_block_device volumes? https://github.com/npalm/terraform-aws-gitlab-runner/blob/develop/main.tf#L218 |
|
thanks, will check the PR in the next days, sorry for the delay |
npalm
approved these changes
Jul 8, 2021
semantic-releaser bot
pushed a commit
that referenced
this pull request
Jul 8, 2021
## [4.26.0](4.25.0...4.26.0) (2021-07-08) ### Features * Add `role_tags` to support tag based authorization ([#333](#333)) ([#335](#335)) ([c81f221](c81f221)) * Make disable_cache configurable ([#324](#324)) ([d726cf4](d726cf4)) * replace default volume type gp2 by gp3 ([#338](#338)) ([1bfaf2b](1bfaf2b)), closes [#318](#318) * upgrade default runner version to 14.0.1 ([#341](#341)) ([18b4103](18b4103)) ### Bug Fixes * add tags for instance profile ([#331](#331)) ([b42712f](b42712f)) * Remove deprecarted null_data_source ([#332](#332)) ([#334](#334)) ([b3ab3f6](b3ab3f6)) * replace deprecated null_data_source with locals ([#336](#336)) ([6a240c9](6a240c9)) * support terraform 1.x ([800c264](800c264)), closes [#330](#330)
|
🎉 This PR is included in version 4.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
radimsuckr
pushed a commit
to radimsuckr/terraform-aws-gitlab-runner
that referenced
this pull request
Jul 29, 2021
## [4.26.0](cattle-ops/terraform-aws-gitlab-runner@4.25.0...4.26.0) (2021-07-08) ### Features * Add `role_tags` to support tag based authorization ([cattle-ops#333](cattle-ops#333)) ([cattle-ops#335](cattle-ops#335)) ([c81f221](cattle-ops@c81f221)) * Make disable_cache configurable ([cattle-ops#324](cattle-ops#324)) ([d726cf4](cattle-ops@d726cf4)) * replace default volume type gp2 by gp3 ([cattle-ops#338](cattle-ops#338)) ([1bfaf2b](cattle-ops@1bfaf2b)), closes [cattle-ops#318](cattle-ops#318) * upgrade default runner version to 14.0.1 ([cattle-ops#341](cattle-ops#341)) ([18b4103](cattle-ops@18b4103)) ### Bug Fixes * add tags for instance profile ([cattle-ops#331](cattle-ops#331)) ([b42712f](cattle-ops@b42712f)) * Remove deprecarted null_data_source ([cattle-ops#332](cattle-ops#332)) ([cattle-ops#334](cattle-ops#334)) ([b3ab3f6](cattle-ops@b3ab3f6)) * replace deprecated null_data_source with locals ([cattle-ops#336](cattle-ops#336)) ([6a240c9](cattle-ops@6a240c9)) * support terraform 1.x ([800c264](cattle-ops@800c264)), closes [cattle-ops#330](cattle-ops#330)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the resource "aws_iam_instance_profile" "instance" has not tags, we need the tags for policy verification purposes