Skip to content

Commit 55435db

Browse files
committed
fixup! feat(pack): add pack-destination config
1 parent 1d94c28 commit 55435db

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/pack.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class Pack extends BaseCommand {
7474
for (const { arg, filename, manifest } of manifests) {
7575
const tarballData = await libpack(arg, this.npm.flatOptions)
7676
const pkgContents = await getContents(manifest, tarballData)
77-
const tarballFilename = path.join(this.npm.config.get('pack-destination'), filename)
77+
const tarballFilename = path.resolve(this.npm.config.get('pack-destination'), filename)
7878

7979
if (!dryRun)
8080
await writeFile(tarballFilename, tarballData)

test/lib/pack.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ t.test('should pack current directory with no arguments', (t) => {
5353

5454
const filename = `npm-${require('../../package.json').version}.tgz`
5555
t.strictSame(OUTPUT, [[filename]])
56-
t.strictSame(tarballFileName, filename)
56+
t.strictSame(tarballFileName, path.resolve(filename))
5757
t.end()
5858
})
5959
})
@@ -87,7 +87,7 @@ t.test('follows pack-destination config', (t) => {
8787

8888
const filename = `npm-${require('../../package.json').version}.tgz`
8989
t.strictSame(OUTPUT, [[filename]])
90-
t.strictSame(tarballFileName, path.join('/tmp/test', filename))
90+
t.strictSame(tarballFileName, path.resolve('/tmp/test', filename))
9191
t.end()
9292
})
9393
})

0 commit comments

Comments
 (0)