You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@@ -73,7 +75,7 @@ All interactions in the npm repository are covered by the [npm Code of Conduct](
73
75
# Make sure you install the dependencies first before running tests.
74
76
$ npm install
75
77
76
-
# Run tests for the CLI (it could take awhile).
78
+
# Run tests for the CLI (it could take a while).
77
79
$ npm run test
78
80
```
79
81
@@ -97,7 +99,7 @@ $ make link
97
99
#################
98
100
# ALTERNATIVELY
99
101
#################
100
-
# If ou're working on a feature or bug, you can run the same command on your
102
+
# If you're working on a feature or bug, you can run the same command on your
101
103
# working branch and link that code.
102
104
103
105
# Create new branch to work from (there are many ways)
@@ -123,14 +125,14 @@ We often want to know if the bug we've fixed for the feature we've added has any
123
125
1. Make a pull-request against this repository
124
126
2. Add the following comment to the pull-request: "`test this please ✅`"
125
127
126
-
This will trigger the [benmark suite](https://github.com/npm/benchmarks) to run against your pull-request, and when it's finished running it will post a comment on your pull-request just like bellow. You'll be able to see the results from the suite inline in your pull-request.
128
+
This will trigger the [benchmark suite](https://github.com/npm/benchmarks) to run against your pull-request, and when it's finished running it will post a comment on your pull-request just like below. You'll be able to see the results from the suite inline in your pull-request.
127
129
128
130
> You'll notice that the bot-user will also add a 🚀 reaction to your comment to
129
131
let you know that it's sent the request to start the benchmark suite.
If you've updated your pull-reuqest and you'd like to run the the benchmark suite again, simple update your original comment, by adding `test this please ✅` again, or simply just adding another emoji to the **end**. _(The trigger is the phrase "test this please ✅" at the beginning of a comment. Updates will trigger as well, so long as the phrase stays at the beginning.)_.
135
+
If you've updated your pull-request and you'd like to run the the benchmark suite again, simple update your original comment, by adding `test this please ✅` again, or simply just adding another emoji to the **end**. _(The trigger is the phrase "test this please ✅" at the beginning of a comment. Updates will trigger as well, so long as the phrase stays at the beginning.)_.
@@ -186,7 +188,6 @@ You'll need a few things installed in order to update and test the CLI project d
186
188
187
189
> Package vendoring is commonly referred to as the case where dependent packages are stored in the same place as your project. That usually means you dependencies are checked into your source management system, such as Git.
188
190
189
-
The CLI project vendors it's dependencies in the `node_modules/` folder. Meaning all the dependencies that the CLI project uses are contained withing the project itself. This is represented by the `bundledDependencies` section in the root level `package.json` file. The main reason for this is because the `npm` CLI project is distributed with the NodeJS runtime and needs to work out of the box, which means all dependencies need to be available after the runtime is installed.
191
+
The CLI project vendors its dependencies in the `node_modules/` folder. Meaning all the dependencies that the CLI project uses are contained withing the project itself. This is represented by the `bundledDependencies` section in the root level `package.json` file. The main reason for this is because the `npm` CLI project is distributed with the NodeJS runtime and needs to work out of the box, which means all dependencies need to be available after the runtime is installed.
190
192
191
193
There are a couple scripts created to help manage this process in the `scripts/` folder.
0 commit comments