Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
9
contributors
Commits on Dec 17, 2022
Commits on Jan 1, 2023
-
fix: evaluate configs in command class
### Refactor Config Reading During `exec` This removes the previous workarounds that were required due to tests setting configs that were not available in the constructor of the commands. This also made the fix for nodejs/node#45881 easier since the config checks for workspaces can now all be made in the command. The fix was to move the package.json detection to `@npmcli/config` and use that boolean instead of setting `location=project` which affected all commands such as `config set` saving to the wrong location. Some notable changes from this refactor include: - `execWorkspaces` no longer being passed the raw workspace filters and instead requiring `this.setWorkspaces()` to be called which was already being done in most commands - `static workspaces = [true|false]` on all commands to indicate workspaces support. This is used in docs generation and whether to throw when `execWorkspaces` is called or not. ### Drop `fakeMockNpm` and refactor `mockNpm` This refactor also drops `fakeMockNpm` in favor of `realMockNpm` (now just `mockNpm`), and adds new features to `mockNpm`. Some new features of `mockNpm`: - sets all configs via argv so they are parsed before `npm.load()`. This is the most important change as it more closely resembles real usage. - automatically resets `process.exitCode` - automatically puts global `node_modules` in correct testdir based on platform - more helpful error messages when used in unsupported ways - ability to preload a command for execution - sets `cwd` automatically to `prefix` and sets `globalPrefix` to the specified testdir Note that this commit does not include the actual test changes, which are included in the following commits for readability reasons. ### Linting This also removes some of the one off linting rules that were set in the past to reduce churn and fixes all remaining errors.
-
-
fix(fund): correctly parse and use
whichconfigPreviously the `which` param in `npm fund` was validated incorrectly leading to `EFUNDNUMBER` errors when used. This fixes that and does a better job detecting when `which` is pointing to an incorrect array bounds in the returned funding array.
-
fix: refactor
helpto use@npmcli/promise-spawnThis also refactors the test to use `mockNpm`
-
fix(init): write package.json workspaces paths with / separators
This also refactors the test to use `mockNpm`
-
-
-
-
chore: convert all test to
mockNpmThis also uses more consistent snapshot cleaning where possible. Note that this is an iterative step for our tests and does not implement `MockRegistry` for them, so many of them still mock important functionality that should be tested. This refactor to `mockNpm` should make it easier to adopt `MockRegistry` as we see fit.
-
-
-
In links with fragments like `#checking-your-version-of-npm-and-node-js` the `node-js` portion doesn't work and should be `nodejs`. So for example, the following link currently on the site does NOT work (i.e. it won't scroll to relevant section): > https://docs.npmjs.com/cli/v9/configuring-npm/install#checking-your-version-of-npm-and-node-js ...but this one (as implemented by this fix) DOES work: > https://docs.npmjs.com/cli/v9/configuring-npm/install#checking-your-version-of-npm-and-nodejs
Commits on Jan 2, 2023
Commits on Jan 9, 2023
-
This: > ...is has the... Should be: > ...it has the...
-
-
docs: fix typos in definitions.js (#6038)
* Fix typo in definitions.js * Fix another typo in definitions.js * Fix yet another typo in definitions.js * update snapshots Co-authored-by: Eric Mutta <eric.mutta@gmail.com>
Commits on Jan 10, 2023
Commits on Jan 12, 2023
-
docs: update outdated file path to definitions.js
Looks like npm's default config options were relocated from `lib/utils/config-defs.js` to the current `lib/utils/config/definitions.js` as [can be seen here](https://github.com/npm/cli/blob/latest/lib/utils/config/definitions.js)
-
-
Commits on Jan 13, 2023
-
fix: use recursive rm in ci command (#6054)
* fix: use recursive rm in ci command * fix: add test for repeat uses of ci command Co-authored-by: Burke Livingston <burkel24@gmail.com>
-
fix: don't try to deprecate nonexistant versions (#6050)
If you pass npm a version that doesn't exist, it still tries to PUT the packument but with no changes. This is unneccessary and currently results in a 422 error from the npm registry
Commits on Jan 17, 2023
Commits on Jan 25, 2023
-
-
feat: added --install-strategy=linked (#6078)
Co-authored-by: Vincent Bailly <vibailly@microsoft.com> Implements the RFC https://github.com/npm/rfcs/blob/main/accepted/0042-isolated-mode.md Packages are installed in node_modules/.store flat, and linked into the node_modules tree in depth, rather than hoisted.
-
Commits on Feb 1, 2023
-
-
-
fix: only save package-lock when truly finished
When we update the trees, the edges are refreshed to correct their specs. If we have written the package-lock before this point, it will be incorrect. No new tests are needed as existing tests were snapshotted w/ the broken behavior, and are fixed now showing this bugfix in action.
-
-
-
-
fix: unpublish with scoped registry
Unpublish now works if you have a scoped registry config
-
-
There are no files selected for viewing