From 022fcf1b0920ab0f83622516bf52c2be325b7483 Mon Sep 17 00:00:00 2001 From: Timson Date: Sun, 28 Mar 2021 05:49:40 +0300 Subject: [PATCH 1/2] fix #45 set command quoted in set command parameter value read from %~p* parameter extension needed to be quoted to avoid special characters from path breaking command --- index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.js b/index.js index 4a7614b..4c72f9a 100644 --- a/index.js +++ b/index.js @@ -86,7 +86,7 @@ const writeShim_ = (from, to, prog, args, variables) => { const head = '@ECHO off\r\n' + 'GOTO start\r\n' + ':find_dp0\r\n' + - 'SET dp0=%~dp0\r\n' + + 'SET "dp0=%~dp0"\r\n' + 'EXIT /b\r\n' + ':start\r\n' + 'SETLOCAL\r\n' + From bffaced7c6221a1f36ac902fa730ec20d9e81d7d Mon Sep 17 00:00:00 2001 From: Timson Date: Sun, 28 Mar 2021 06:24:32 +0300 Subject: [PATCH 2/2] test snapshots fixed --- tap-snapshots/test-basic.js-TAP.test.js | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tap-snapshots/test-basic.js-TAP.test.js b/tap-snapshots/test-basic.js-TAP.test.js index 802f3eb..50b5c7b 100644 --- a/tap-snapshots/test-basic.js-TAP.test.js +++ b/tap-snapshots/test-basic.js-TAP.test.js @@ -9,7 +9,7 @@ exports[`test/basic.js TAP env shebang > cmd 1`] = ` @ECHO off\\r GOTO start\\r :find_dp0\\r -SET dp0=%~dp0\\r +SET "dp0=%~dp0"\\r EXIT /b\\r :start\\r SETLOCAL\\r @@ -78,7 +78,7 @@ exports[`test/basic.js TAP env shebang with args > cmd 1`] = ` @ECHO off\\r GOTO start\\r :find_dp0\\r -SET dp0=%~dp0\\r +SET "dp0=%~dp0"\\r EXIT /b\\r :start\\r SETLOCAL\\r @@ -147,7 +147,7 @@ exports[`test/basic.js TAP env shebang with variables > cmd 1`] = ` @ECHO off\\r GOTO start\\r :find_dp0\\r -SET dp0=%~dp0\\r +SET "dp0=%~dp0"\\r EXIT /b\\r :start\\r SETLOCAL\\r @@ -217,7 +217,7 @@ exports[`test/basic.js TAP explicit shebang > cmd 1`] = ` @ECHO off\\r GOTO start\\r :find_dp0\\r -SET dp0=%~dp0\\r +SET "dp0=%~dp0"\\r EXIT /b\\r :start\\r SETLOCAL\\r @@ -286,7 +286,7 @@ exports[`test/basic.js TAP explicit shebang with args > cmd 1`] = ` @ECHO off\\r GOTO start\\r :find_dp0\\r -SET dp0=%~dp0\\r +SET "dp0=%~dp0"\\r EXIT /b\\r :start\\r SETLOCAL\\r @@ -355,7 +355,7 @@ exports[`test/basic.js TAP if exists (it does exist) > cmd 1`] = ` @ECHO off\\r GOTO start\\r :find_dp0\\r -SET dp0=%~dp0\\r +SET "dp0=%~dp0"\\r EXIT /b\\r :start\\r SETLOCAL\\r @@ -400,7 +400,7 @@ exports[`test/basic.js TAP just proceed if reading fails > cmd 1`] = ` @ECHO off\\r GOTO start\\r :find_dp0\\r -SET dp0=%~dp0\\r +SET "dp0=%~dp0"\\r EXIT /b\\r :start\\r SETLOCAL\\r @@ -445,7 +445,7 @@ exports[`test/basic.js TAP no shebang > cmd 1`] = ` @ECHO off\\r GOTO start\\r :find_dp0\\r -SET dp0=%~dp0\\r +SET "dp0=%~dp0"\\r EXIT /b\\r :start\\r SETLOCAL\\r