Skip to content

Commit 3d6255f

Browse files
devsnekjuanarbol
authored andcommitted
deps: V8: cherry-pick cc9a8a37445e
Original commit message: fix overflow check in error formatting Bug: v8:12494 Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Gus Caplan <[email protected]> Cr-Commit-Position: refs/heads/main@{#78909} Refs: v8/v8@cc9a8a3 PR-URL: nodejs#41826 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Danielle Adams <[email protected]>
1 parent b89d4ef commit 3d6255f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

deps/v8/src/execution/messages.cc

+2-1
Original file line numberDiff line numberDiff line change
@@ -858,7 +858,8 @@ MaybeHandle<Object> ErrorUtils::FormatStackTrace(Isolate* isolate,
858858
Handle<FixedArray> elems = Handle<FixedArray>::cast(raw_stack);
859859

860860
const bool in_recursion = isolate->formatting_stack_trace();
861-
if (!in_recursion) {
861+
const bool has_overflowed = i::StackLimitCheck{isolate}.HasOverflowed();
862+
if (!in_recursion && !has_overflowed) {
862863
Handle<Context> error_context = error->GetCreationContext();
863864
DCHECK(error_context->IsNativeContext());
864865

0 commit comments

Comments
 (0)