Skip to content

release please with root + workspaces #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukekarrys opened this issue Apr 6, 2022 · 1 comment
Closed

release please with root + workspaces #126

lukekarrys opened this issue Apr 6, 2022 · 1 comment

Comments

@lukekarrys
Copy link
Contributor

This is not currently an issue since we currently only use workspaces in the cli and we DONT use release please to release the cli.

But I wanted to point out that currently release-please cannot exclude any paths when creating a release (googleapis/release-please#908). So if we were to publish the cli in the future, we would need to move it into its own workspace inside a private: true root workspace.

This is something to keep in mind if we plan to do that and if we plan to make other repos into monorepos.

@lukekarrys
Copy link
Contributor Author

This was done by #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant