Skip to content

package.json scripts should use double quotes #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XhmikosR opened this issue Feb 26, 2022 · 2 comments
Closed

package.json scripts should use double quotes #63

XhmikosR opened this issue Feb 26, 2022 · 2 comments

Comments

@XhmikosR
Copy link

Another thing I noticed in some npm projects is the use of ' in the npm scripts, for example:

"lint": "eslint '**/*.js'",

This won't work in all shells and can cause issues. Using double quotes will work everywhere.

I should probably make a new issue about this, I'm just not sure if this is handled here.

EDIT, NVM I just saw it's handled here :)

lint: `eslint '**/*.js'`,

Originally posted by @XhmikosR in #62 (comment)

@XhmikosR
Copy link
Author

This is what happens with single quotes on Windows 10 cmd:

C:\Users\xmr\Desktop\gauge>npm run lint

> [email protected] lint
> eslint '**/*.js'


Oops! Something went wrong! :(

ESLint: 8.10.0

No files matching the pattern "'**/*.js'" were found.
Please check for typing mistakes in the pattern.

Using double quotes will work everywhere.

@lukekarrys
Copy link
Contributor

closed by #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants