Commit 5db8cdd9 appears to break file_browser functionality when cwd is not in a git repo

[SRKX0A]

Description

Running the file_browser extension fails when not inside a git repo.

I believe this is caused by the new job error handling relying on the existence of stderr output to conclude that an error has occurred, but whatever git command ends up generating some (if the cwd has no .git folder). Maybe there's a better way?

Snippet of relevant error message when trying to use :Telescope file_browser:

[telescope] [WARN 02:06:29] /home/XXX/.local/share/nvim/site/pack/packer/start/telescope.nvim/lua/telescope/pickers.lua:493: Finder failed with msg: ...er.nvim/lua/telescope/_extensions/file_browser/utils.lua:237: fatal: not a git repository (or any of the parent directories): .git

Thanks for all of your hard work developing this plugin!

Neovim version

NVIM v0.9.1
Build type: Release
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/x86_64-pc-linux-gnu-gcc  -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wvla -Wdouble-promotion -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-prototypes -fno-common -Wno-unused-result -Wimplicit-fallthrough -fdiagnostics-color=always -fstack-protector-strong -DUNIT_TESTING -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -I/usr/include/luajit-2.1 -I/usr/include -I/usr/include -I/var/tmp/portage/app-editors/neovim-0.9.1/work/neovim-0.9.1_build/src/nvim/auto -I/var/tmp/portage/app-editors/neovim-0.9.1/work/neovim-0.9.1_build/include -I/var/tmp/portage/app-editors/neovim-0.9.1/work/neovim-0.9.1_build/cmake.config -I/var/tmp/portage/app-editors/neovim-0.9.1/work/neovim-0.9.1/src -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include

   system vimrc file: "/etc/vim/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

Operating system and version

Gentoo Linux

Steps to reproduce

In a shell:

1. cd to directory without a .git folder
2. nvim
3. :Telescope file_browser

Expected behavior

Files and folders should show up in the file_browser picker.

Actual behavior

Nothing shows up in the file_browser picker.

Minimal config

vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvim/site]]
local package_root = '/tmp/nvim/site/pack'
local install_path = package_root .. '/packer/start/packer.nvim'
local function load_plugins()
  require('packer').startup {
    {
      'wbthomason/packer.nvim',
      {
        'nvim-telescope/telescope.nvim',
        requires = {
          'nvim-lua/plenary.nvim',
          'nvim-telescope/telescope-file-browser.nvim',
        },
      },
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. '/plugin/packer_compiled.lua',
      display = { non_interactive = true },
    },
  }
end
_G.load_config = function()
  require('telescope').setup()
  require('telescope').load_extension('file_browser')
  -- ADD INIT.LUA SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing Telescope and dependencies.")
  vim.fn.system { 'git', 'clone', '--depth=1', 'https://github.com/wbthomason/packer.nvim', install_path }
end
load_plugins()
require('packer').sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua load_config()]]

[jamestrew]

Thanks for catching and reporting. I'm just going to go back to letting git silently error out for now.