fix(platform): add osx multiple locale support #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @nurishi. Clear description. I can't test it right now though unfortunately |
ziadkh0
reviewed
Nov 22, 2017
lib/index.js
Outdated
| @@ -413,11 +413,11 @@ NwBuilder.prototype.copyNwjs = function () { | |||
| var options = {}; | |||
|
|
|||
| if(['nw', 'nwjs.app', 'nw.exe'].indexOf(destFile) !== -1){ | |||
| // ignore nwjs.app/Contents/Resources/*.lproj, otherwise the app name will show as nwjs.app in | |||
| // ignore nwjs.app/Contents/Resources/*.lproj/InfoPlist.strings, otherwise the app name will show as nwjs.app in. *.lproj directory itself needs to be kept to support multiple locales. | |||
There was a problem hiding this comment.
The word Finder (from the next line) should come after nwjs.app in (as in ... nwjs.app in Finder. *.lproj ...)
|
@nurishi I'm in the process of cleaning up PRs and issues. Could you please confirm / make sure the code here is up to date? |
limitedeternity
added a commit
to limitedeternity/nw-builder
that referenced
this pull request
Feb 1, 2019
|
This PR is still required and would fix issue my issue #524 |
ayushmanchhabra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into the issue that OSX multi locale support becomes unavailable when we build with nw-builder. (Tested with nw-builder 3.1.2 and nwjs 0.14.7 SDK build which works fine with their official build. FYI, currently 0.14.7 Normal build has an issue in multi locale support nwjs/nw.js#4824 so you can only check it with SDK build unless you manually apply the fix suggested in the ticket to Normal build)
Found out the root cause of the issue and it was in the part of omitting creation of Contents/Resources/*.lproj directories. I understand that this line was required to support the custom app name but instead of dropping the whole directory, it should only ignore InfoPlist.string file inside so that the directory itself will be still generated.
Hope this pull request could be merged and save the people facing the same issue.