Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package and distribute docs to be based off nwjs-builder rather than nw-builder. #5054

Closed
orther opened this issue Jun 29, 2016 · 10 comments
Assignees

Comments

@orther
Copy link

orther commented Jun 29, 2016

Considering nw-builder doesn't seem to support the versions after 0.12.3 of nw.js (I had tons of issues and ended up moving on to nwjs-builder) I believe nwjs-builder should replace nw-builder on the Package and Distribute doc page. I was considering forking this repo and updating the Package and Distribute page to link to and show nwjs-builder examples rather than nw-builder but before I spend time doing that I wanted to ask if that is something you would even appreciate/consider for pulling?

If people haven't looked at nwjs-builder for a robust easy way to build nwjs v0.13.x+ apps for the 3 major platforms (OSX, Windows, Linux) I highly recommend you take a look.

@rogerwang
Copy link
Member

CC @adam-lynch

@adam-lynch
Copy link

@orther thanks for the feedback. Sorry about this. We're working on it right now and we're very close. The creator of nwjs-builder is onboard. See #327 and #333. It just needs to be tested a bit more (I'll be doing some testing on Windows myself today). If you want to test that branch, you can via npm i --save nwjs/nw-builder#newer_versions.

So... soon nw-builder will be fine and then we'll move onto adding stuff like the ability to choose flavors and other stuff. So I think this can be closed. Thanks again.

@adam-lynch
Copy link

Woops, I mean nwutils/nw-builder#327 and nwutils/nw-builder#333

@orther
Copy link
Author

orther commented Jun 30, 2016

I'll likely get testing and involved in helping update nwjs/nw-builder once I get some more free time (i.e. after I'm done pushing my nwjs based app's major release and migration to nwjs v0.15.4) in a week or two.

Thanks for the feedback @adam-lynch

@adam-lynch
Copy link

👍

@rogerwang
Copy link
Member

rogerwang commented Jul 20, 2016

I don't see any one is picking up nwjs/nw-builder so far. So I'm re-opening this issue for the official documentation. CC @evshiron

@ghostoy please check whether the steps in the official documentation are good asap. If they are broken, the official documentation should be fixed immediately.

@evshiron
Copy link
Contributor

I have watched nwutils/nw-builder#327 but I am afraid I am not going to bother maintaining 2 similar projects, when to me nwjs-builder is more familiar and requires less efforts.
I am glad that nwjs-builder could be listed in the documentation as an option for building applications. It's not widely used though, but things should just work.
If there is anything I can help, let me know.

@rogerwang
Copy link
Member

Thanks @evshiron I didn't notice the name difference.

We are thinking about the change for official doc but we'll for sure list your project since it's actively maintained.

@chino23
Copy link

chino23 commented Jul 22, 2016

those builders are greatly appreciated!

@ghostoy
Copy link
Member

ghostoy commented Jul 25, 2016

Currently both nw-builder and nwjs-builder are listed as recommended tools for packing NW.js based apps on official document site. Close this issue.

@ghostoy ghostoy closed this as completed Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants