Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW2: win.show() restores window #7278

Closed
AshleyScirra opened this issue Dec 17, 2019 · 1 comment
Closed

NW2: win.show() restores window #7278

AshleyScirra opened this issue Dec 17, 2019 · 1 comment
Labels

Comments

@AshleyScirra
Copy link

NWJS Version : 0.43.1
Operating System : Windows 10 64-bit

Expected behavior

Calling win.show() after win.maximize() should show a maximized window.

Actual behavior

In NW2 mode, the call to win.show() restores the window so it does not appear maximized. With --disable-features=nw2 it works correctly again.

The setting for window.show in package.json does not appear to affect the issue.

The workaround is easy - just call show() before maximize() - but it's a breaking change in NW2.

How to reproduce

Minimal repro:
window-show-bug.zip

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants