[FIX] evaluation: invalidate on concurrent dropped command

Task: 4567308
Part-of: #5739
Signed-off-by: Rémi Rahir (rar) <[email protected]>
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>

Author: pro-odoo

src/model.ts

@@ -365,6 +365,11 @@ export class Model extends EventBus<any> implements CommandDispatcher {
         dispatch: (command: CoreCommand) => {
           const result = this.checkDispatchAllowed(command);
           if (!result.isSuccessful) {
+            // core views plugins need to be invalidated
+            this.dispatchToHandlers(this.coreHandlers, {
+              type: "UNDO",
+              commands: [command],
+            });
             return;
           }
           this.isReplayingCommand = true;

tests/collaborative/collaborative.test.ts

@@ -654,6 +654,22 @@ describe("Multi users synchronisation", () => {
       expect(getEvaluatedCell(bob, "A1", "sheet2").value).toBe(2);
       functionRegistry.remove("GET.ASYNC.VALUE");
     });
+
+    test("evaluation is recomputed after command is rejected because of a concurrent update", () => {
+      createSheet(bob, { sheetId: "sheet2" });
+      network.concurrent(() => {
+        hideSheet(alice, "sheet2");
+        // this command is first accepted on Charlie's side
+        // but later rejected because there's actually only one visible sheet
+        deleteSheet(charlie, "Sheet1");
+      });
+      setCellContent(charlie, "A1", "hello", "Sheet1");
+      expect([alice, bob, charlie]).toHaveSynchronizedExportedData();
+      expect([alice, bob, charlie]).toHaveSynchronizedValue(
+        (user) => getEvaluatedCell(user, "A1").value,
+        "hello"
+      );
+    });
   });
 
   test("Reorder formatting rules concurrently", () => {

tests/collaborative/collaborative_history.test.ts

@@ -918,6 +918,18 @@ describe("Collaborative local history", () => {
     );
   });
 
+  test("Evaluation is the same after a sheet deletion replayed", () => {
+    const { network, alice, bob, charlie } = setupCollaborativeEnv();
+    setCellContent(alice, "A1", "hello");
+    duplicateSheet(charlie, "Sheet1", "duplicateSheetId");
+    network.concurrent(() => {
+      hideSheet(bob, "Sheet1");
+      deleteSheet(charlie, "Sheet1");
+    });
+    expect([alice, bob, charlie]).toHaveSynchronizedEvaluation();
+    expect([alice, bob, charlie]).toHaveSynchronizedExportedData();
+  });
+
   test("transform target command with column addition before the target edge", () => {
     addColumns(charlie, "before", "B", 1);
     network.concurrent(() => {