Property Error Bugfix

Author: ThomasSchneider-94

estate/models/estate_property_offer.py

@@ -1,7 +1,9 @@
-from odoo import api, fields, models, exceptions
+"""Odoo modules"""
 from dateutil.relativedelta import relativedelta
+from odoo import api, fields, models, exceptions
 
 class EstatePropertyOffer(models.Model):
+    '''Offer for an estate property'''
     _name = "estate.property.offer"
     _description = "Offer for a property"
     _order = "price desc"
@@ -18,57 +20,58 @@ class EstatePropertyOffer(models.Model):
     validity = fields.Float(default = 7, string = "Validity")
     property_type_id = fields.Many2one(related="property_id.property_type_id")
 
-    
+
 
     _sql_constraints = [('check_price', 'CHECK(price > 0)', 'The price must be strictly positive.')]
 
 
 
     @api.model
-    def create(self, vals):
-        
-        self.env['estate.property'].browse(vals['property_id']).state = 'offer_received'
+    def create(self, vals_list):
+        '''Change property state and add price warning on creation'''
+        self.env['estate.property'].browse(vals_list['property_id']).state = 'offer_received'
 
         if self.env['estate.property'].browse(vals['property_id']).offer_ids:
             if vals['price'] < min(self.env['estate.property'].browse(vals['property_id']).offer_ids.mapped('price')):
                 raise exceptions.UserError("You are trying to create the lowest offer")
 
-        return super().create(vals)
+        return super().create(vals_list)
 
     @api.depends("validity")
     def _compute_date_deadline(self):
         for record in self:
-            if (record.create_date):
+            if record.create_date:
                 record.date_deadline = record.create_date + relativedelta(days = record.validity)
             else:
                 record.date_deadline = fields.Date.today() + relativedelta(days = record.validity)
 
     @api.depends("date_deadline")
     def _inverse_date_deadline(self):
         for record in self:
-            if (record.create_date):
+            if record.create_date:
                 record.validity = relativedelta(record.date_deadline , record.create_date).days
             else:
                 record.validity = relativedelta(record.date_deadline, fields.Date.today()).days
 
 
 
     def accept_offer(self):
+        '''Accept an offer'''
         for record in self:
             for offer_id in record.property_id.offer_ids:
                 if offer_id.status == 'accepted':
                     raise exceptions.UserError("Another offer is already accepted")
-                    return True
 
             record.status = 'accepted'
             record.property_id.buyer_id = record.partner_id
             record.property_id.selling_price = record.price
 
         return True
-    
+
     def refuse_offer(self):
+        '''Refuse an offer'''
         for record in self:
-            if (record.status == 'accepted'):
+            if record.status == 'accepted':
                 record.property_id.buyer_id = False
                 record.property_id.selling_price = 0