[IMP] improved code readability and deleted duplicates

Author: Syozik

estate/models/estate_property.py

@@ -54,14 +54,6 @@ class Property(models.Model):
     total_area = fields.Float("Total area (sqm)", compute="_compute_area")
     best_price = fields.Float("Best price", compute="_compute_best_price")
 
-    @api.constrains("expected_price", "selling_price")
-    def _check_price(self):
-        for record in self:
-            if record.selling_price and record.expected_price and not tools.float_utils.float_is_zero(record.selling_price, precision_digits=2):
-                if record.selling_price < 0.9 * record.expected_price:
-                    raise exceptions.ValidationError(
-                        "The selling price cannot be lower than 90% of the expected price.")
-
     @api.depends("living_area", "garden_area")
     def _compute_area(self):
         for record in self:
@@ -70,7 +62,7 @@ def _compute_area(self):
     @api.depends("offer_ids.price")
     def _compute_best_price(self):
         for record in self:
-            record.best_price = max([0]+record.offer_ids.mapped('price'))
+            record.best_price = max([0] + record.offer_ids.mapped('price'))
 
     @api.onchange("garden")
     def _onchange_garden(self):
@@ -109,7 +101,6 @@ def _check_price(self):
                 if record.selling_price < 0.9 * record.expected_price:
                     raise exceptions.ValidationError(
                         "The selling price cannot be lower than 90% of the expected price.")
-                
 
     @api.ondelete(at_uninstall=False)
     def _not_delete_if_not_new_or_canceled(self):