Skip to content

Commit c9a6d38

Browse files
committed
fix: function alias renamed to aliasWebpack #60
BREAKING CHANGE: The `alias` function has been renamed to `aliasWebpack` to improve the readability of the rewire API, as part of a major release along with a rename of the library itself.
1 parent c2a4633 commit c9a6d38

File tree

5 files changed

+38
-18
lines changed

5 files changed

+38
-18
lines changed

docs/migration.md

+28-8
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,44 @@
11
# Migration
22

3-
# Migration from react-app-rewired-alias
3+
## Migration from react-app-rewired-alias
44

5-
Dangerous mode is renamed to extended/extremal. The implementation
6-
for dangerous mode is moved to separaded liblrary with suffix **`-ex`**.
5+
### Generic mode
76

87
* Replace library name for generic mode
98

109
```diff
11-
- const {alias} = require('react-app-rewire-alias')
12-
+ const {alias} = require('react-app-alias')
10+
- const {...} = require('react-app-rewire-alias')
11+
+ const {...} = require('react-app-alias')
1312
```
1413

14+
* Rename function `alias` to `aliasWebpack`
15+
16+
```diff
17+
- const {alias} = require('react-app-alias')
18+
+ const {aliasWebpack} = require('react-app-alias')
19+
```
20+
21+
### Dangerous mode
22+
23+
Dangerous mode is renamed to extended/extremal and the implementation
24+
is moved to separated liblrary with suffix **`-ex`**.
25+
1526
* Replace library name for dangerous mode,
1627
* Remove `/lib/aliasDangerous` path part from import,
1728
* Notice that library name is different (suffix `-ex` added),
18-
* Fangerous mode function `aliasDangerous` for `react-app-rewired` or `customize-cra` is renamed to `alias`.
1929

2030
```diff
21-
- const {aliasDangerous} = require('react-app-rewired-alias/lib/aliasDangerous')
22-
+ const {alias} = require('react-app-alias-ex')
31+
- const {...} = require('react-app-rewired-alias/lib/aliasDangerous')
32+
+ const {...} = require('react-app-alias-ex')
2333
```
2434

35+
* For dangerous mode function `aliasDangerous` for `react-app-rewired` or `customize-cra` is renamed to `aliasWebpack` (also same as function `alias` for generic mode).
36+
37+
* Rename function `alias` to `aliasWebpack`
38+
39+
```diff
40+
- const {aliasDangerous} = require('react-app-alias-ex')
41+
+ const {aliasWebpack} = require('react-app-alias-ex')
42+
```
43+
44+

example/above/config-overrides.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
const {aliasDangerous, aliasJest, configPaths} = require('react-app-alias-ex')
1+
const {aliasWebpack, aliasJest, configPaths} = require('react-app-alias-ex')
22

33
const aliasPaths = configPaths('./tsconfig.paths.json')
44

5-
module.exports = aliasDangerous(aliasPaths)
5+
module.exports = aliasWebpack(aliasPaths)
66
module.exports.jest = aliasJest(aliasPaths)

example/main/config-overrides.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
const {alias, aliasJest, configPaths} = require('react-app-alias')
1+
const {aliasWebpack, aliasJest, configPaths} = require('react-app-alias')
22

33
const aliasPaths = configPaths('./tsconfig.paths.json')
44

5-
module.exports = alias(aliasPaths)
5+
module.exports = aliasWebpack(aliasPaths)
66
module.exports.jest = aliasJest(aliasPaths)

packages/react-app-alias-ex/src/index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ function aliasJest(aliasMap) {
120120
}
121121
}
122122

123-
function aliasDangerous(aliasMap) {
123+
function aliasWebpack(aliasMap) {
124124
const aliasLocal = Object.keys(aliasMap).reduce( (a,i) => {
125125
a[i] = path.resolve(paths.appPath, aliasMap[i])
126126
return a
@@ -136,15 +136,15 @@ function aliasDangerous(aliasMap) {
136136

137137
const CracoAliasPlugin = {
138138
overrideWebpackConfig: function({webpackConfig, pluginOptions}) {
139-
return aliasDangerous(pluginOptions.alias||configPaths())(webpackConfig)
139+
return aliasWebpack(pluginOptions.alias||configPaths())(webpackConfig)
140140
},
141141
overrideJestConfig: function({jestConfig, pluginOptions}) {
142142
return aliasJest(pluginOptions.alias||configPaths())(jestConfig)
143143
}
144144
}
145145

146146
module.exports = {
147-
aliasDangerous,
147+
aliasWebpack,
148148
aliasJest,
149149
configPaths,
150150
expandResolveAlias,

packages/react-app-alias/src/index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ function checkOutside(aliasMap) {
4949
const outside = Object.keys(aliasMap).reduce( (a, i) => {
5050
if(isOutsideOfRoot(aliasMap[i])) {
5151
console.error(
52-
`alias '${i}' is outside of root - supported only by aliasDangerous`
52+
`alias '${i}' is outside of root - supported only by react-app-alias-ex`
5353
)
5454
return true
5555
}
@@ -63,7 +63,7 @@ function checkOutside(aliasMap) {
6363
}
6464
}
6565

66-
function alias(aliasMap) {
66+
function aliasWebpack(aliasMap) {
6767
checkOutside(aliasMap)
6868
const aliasLocal = Object.keys(aliasMap).reduce( (a,i) => {
6969
a[i] = path.resolve(paths.appPath, aliasMap[i])
@@ -154,7 +154,7 @@ const CracoAliasPlugin = {
154154
}
155155

156156
module.exports = {
157-
alias,
157+
aliasWebpack,
158158
aliasJest,
159159
configFilePath,
160160
configPathsRaw,

0 commit comments

Comments
 (0)