Name jdbc spans according to db operation/procedure name and not database name

[akats7]

Is your feature request related to a problem? Please describe.
We are exporting trace data to New Relic and want to use the database transaction tab to identify db operations that are the most time consuming/ introducing the most latency. However, NR queries the db transaction off the name of the span which in this case (due to the lack of support for procedures) is db_name. This makes it very difficult to identify which db operations are causing issues.

Describe the solution you'd like
I would like the jdbc spans to be named according to the operation (i.e, in the case of stored procedures, name according to the stored procedure name),

Additional context
I'm looking on guidance on this, is there a reason this wasn't the default functionality, and if it deemed to be useful I'd be happy to discuss some approaches.

[trask]

hi @akats7!

I believe the jdbc span name should be <db.operation> <db.name>.<db.sql.table>, but it sounds like you are only seeing <db.name>?

that could be happening if we aren't able to parse out the operation and table from the query, so would be helpful to see specific queries and resulting span names you are seeing.

[akats7]

Hi @trask,

Thanks for the reply, so it looks like even when all of the fields are able to be extracted, the span would be something along the lines of INSERT postgres.table1, what I was wondering is if it would be of interest for the name to essentially be spInsertUser, that way I can actually delineate which procedures are taking longer than others as many procedures might have the same <db.operation> <db.name>.<db.sql.table> permutation

[trask]

hey @akats7, are you specifically referring to the naming of stored procedures? maybe if you could give a few examples of complete sql statements and how you would propose to name them it might help to clarify, thx!

[akats7]

Hi @trask, yes I'm specifically referring to called stored procedures, is the proper naming for a stored procedure in the format "Call db_name.procedure_name", this seems to be the case when I see only the db.name get parsed out, and in turn the span is named "db_name"

[trask]

yes I'm specifically referring to called stored procedures

makes sense to me, as stored procedure names are cardinality limited

stored procedures are even called out explicitly in the spec:

The span name SHOULD be set to a low cardinality value representing the statement executed on the database. It MAY be a stored procedure name (without arguments)

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md#semantic-conventions-for-database-client-calls

[akats7]

Hi @trask, just wanted to clarify, is this a valid enhancement. Just want to ensure that similar instrumentation does not already exist/existed in the past within the agent.

[trask]

just wanted to clarify, is this a valid enhancement

I believe so

[akats7]

Can I please be assigned this issue

[mateuszrzeszutek]

Fixed by #7557