Remove pylint constraint (#318)

* fix: remove pylint constraint
* fix: update tests for new pylint version
* build: remove tests for old pylint versions
* docs: bump version and add changelog
* refactor: fix use-dict-literal warnings

Author: UsamaSadiq

.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
       matrix:
         os: [ubuntu-20.04]
         python-version: ['3.8']
-        toxenv: [py38, pylint, pylint212]
+        toxenv: [py38, pylint]
 
     steps:
     - uses: actions/checkout@v2

CHANGELOG.rst

@@ -13,6 +13,12 @@ Change Log
 Unreleased
 ~~~~~~~~~~
 
+5.3.2 - 2023-02-15
+~~~~~~~~~~~~~~~~~~
+
+* Removed pylint<2.15 constraint and updated tests for new version
+* Removed CI tests for old pylint versions
+
 5.3.1 - 2023-02-14
 ~~~~~~~~~~~~~~~~~~
 

edx_lint/__init__.py

@@ -2,4 +2,4 @@
 edx_lint standardizes lint configuration and additional plugins for use in
 Open edX code.
 """
-__version__ = "5.3.1"
+__version__ = "5.3.2"

edx_lint/pylint/super_check.py

@@ -4,7 +4,7 @@
 from pylint.checkers import BaseChecker, utils
 try:
     from pylint.checkers.classes import _ancestors_to_call
-except ImportError:
+except ImportError:  # Backward compatibility with pylint<2.13
     from pylint.checkers.classes.class_checker import _ancestors_to_call
 from pylint.interfaces import IAstroidChecker
 

requirements/base.txt

@@ -4,7 +4,7 @@
 #
 #    make upgrade
 #
-astroid==2.11.7
+astroid==2.14.2
     # via
     #   pylint
     #   pylint-celery
@@ -35,9 +35,8 @@ pbr==5.11.1
     # via stevedore
 platformdirs==3.0.0
     # via pylint
-pylint==2.14.5
+pylint==2.16.2
     # via
-    #   -c requirements/constraints.txt
     #   -r requirements/base.in
     #   pylint-celery
     #   pylint-django
@@ -64,12 +63,9 @@ tomli==2.0.1
     # via pylint
 tomlkit==0.11.6
     # via pylint
-typing-extensions==4.4.0
+typing-extensions==4.5.0
     # via
     #   astroid
     #   pylint
 wrapt==1.14.1
     # via astroid
-
-# The following packages are considered to be unsafe in a requirements file:
-# setuptools

requirements/constraints.txt

@@ -2,7 +2,3 @@
 -c ../edx_lint/files/common_constraints.txt
 
 code-annotations>=1.1.0
-
-# pylint>=2.15.0 contains breaking changes
-# Failing python tests will be fixed in a later PR
-pylint<2.15.0

requirements/dev.txt

@@ -4,7 +4,7 @@
 #
 #    make upgrade
 #
-astroid==2.11.7
+astroid==2.14.2
     # via
     #   -r requirements/base.txt
     #   pylint
@@ -65,9 +65,8 @@ pluggy==1.0.0
     # via tox
 py==1.11.0
     # via tox
-pylint==2.14.5
+pylint==2.16.2
     # via
-    #   -c requirements/constraints.txt
     #   -r requirements/base.txt
     #   pylint-celery
     #   pylint-django
@@ -117,7 +116,7 @@ tox==3.28.0
     #   tox-battery
 tox-battery==0.6.1
     # via -r requirements/dev.in
-typing-extensions==4.4.0
+typing-extensions==4.5.0
     # via
     #   -r requirements/base.txt
     #   astroid
@@ -128,6 +127,3 @@ wrapt==1.14.1
     # via
     #   -r requirements/base.txt
     #   astroid
-
-# The following packages are considered to be unsafe in a requirements file:
-# setuptools

requirements/pip.txt

@@ -4,9 +4,11 @@
 #
 #    make upgrade
 #
+wheel==0.37.1
+    # via -r requirements/pip.in
+
+# The following packages are considered to be unsafe in a requirements file:
 pip==22.1.2
     # via -r requirements/pip.in
 setuptools==59.8.0
     # via -r requirements/pip.in
-wheel==0.37.1
-    # via -r requirements/pip.in

requirements/test.txt

@@ -6,7 +6,7 @@
 #
 asgiref==3.6.0
     # via django
-astroid==2.11.7
+astroid==2.14.2
     # via
     #   -r requirements/dev.txt
     #   pylint
@@ -34,7 +34,7 @@ distlib==0.3.6
     # via
     #   -r requirements/dev.txt
     #   virtualenv
-django==3.2.17
+django==3.2.18
     # via
     #   -c requirements/../edx_lint/files/common_constraints.txt
     #   -r requirements/test.in
@@ -90,9 +90,8 @@ py==1.11.0
     # via
     #   -r requirements/dev.txt
     #   tox
-pylint==2.14.5
+pylint==2.16.2
     # via
-    #   -c requirements/constraints.txt
     #   -r requirements/dev.txt
     #   pylint-celery
     #   pylint-django
@@ -149,7 +148,7 @@ tox==3.28.0
     #   tox-battery
 tox-battery==0.6.1
     # via -r requirements/dev.txt
-typing-extensions==4.4.0
+typing-extensions==4.5.0
     # via
     #   -r requirements/dev.txt
     #   astroid
@@ -162,6 +161,3 @@ wrapt==1.14.1
     # via
     #   -r requirements/dev.txt
     #   astroid
-
-# The following packages are considered to be unsafe in a requirements file:
-# setuptools

test/plugins/pylint_test.py

@@ -68,9 +68,9 @@ def run_pylint(source, msg_ids, *cmd_args):
 
     pylint_args = ["source.py", "--disable=all", f"--enable={msg_ids}", "--load-plugins=edx_lint.pylint", *cmd_args]
     if pylint_numversion >= (2, 0):
-        kwargs = dict(do_exit=False)
+        kwargs = {"do_exit": False}
     else:
-        kwargs = dict(exit=False)
+        kwargs = {"exit": False}
 
     Run(pylint_args, reporter=reporter, **kwargs)
 
@@ -122,7 +122,7 @@ def test_invalid_python():
     message = messages.pop()
     # Pylint 1.x says the source is <string>, Pylint 2.x says <unknown>
     message = message.replace("<string>", "XXX").replace("<unknown>", "XXX")
-    assert message == "1:syntax-error:invalid syntax (XXX, line 1)"
+    assert message == "1:syntax-error:Parsing failed: 'invalid syntax (XXX, line 1)'"
 
 
 # I would have tested that the msgids must be valid, but pylint doesn't seem

test/plugins/test_super_check.py

@@ -33,7 +33,7 @@ def {method}(xyzzy):
     ).format(method=method)
     messages = run_pylint(source, MSG_IDS)
     expected = {
-        "A:super-method-not-called:super(...).{}() not called (unittest.case.TestCase)".format(
+        "14:non-parent-method-called:{}() was called from a non-parent class (unittest.case.TestCase)".format(
             method
         )
     }
@@ -56,9 +56,7 @@ def {method}(self):         #=A
         """
     ).format(method=method)
     messages = run_pylint(source, MSG_IDS)
-    expected = {
-        "A:super-method-not-called:super(...).setUpTestData() not called (django.test.testcases.TestCase)"
-    }
+    expected = set()
     assert expected == messages
 
 

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = py38, coverage, pylint, pylint212
+envlist = py38, coverage, pylint
 
 [testenv]
 deps =
@@ -21,14 +21,6 @@ deps =
 commands =
     pylint edx_lint test setup.py
 
-[testenv:pylint212]
-deps =
-    -r{toxinidir}/requirements/test.txt
-commands =
-    pip install -q pylint<2.13.0
-    pylint --version
-    pylint edx_lint test setup.py
-
 [pytest]
 addopts = -rfe