Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed course level preference issue #1209

Open
wants to merge 4 commits into
base: 2u-main
Choose a base branch
from

Conversation

sundasnoreen12
Copy link
Contributor

INF-1797

Description

We deprecated the “Never” email frequency for emails a while ago.

However, it is still persisting for people who had selected it before deprecation. Even if someone turns on email notifications toggle, “Never” persists.

Acceptance Criteria

Modify UX such that when a person turns on email toggle for a preference from COURSE or ACCOUNT level, the email cadences for that preference should change to “Daily” no matter what it was before (Never/Weekly/Daily).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@sundasnoreen12 sundasnoreen12 changed the base branch from master to 2u-main March 11, 2025 16:31
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.76%. Comparing base (b103775) to head (1eda648).
Report is 1 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/notification-preferences/data/thunks.js 83.33% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           2u-main    #1209      +/-   ##
===========================================
+ Coverage    58.00%   58.76%   +0.76%     
===========================================
  Files          119      119              
  Lines         2393     2401       +8     
  Branches       656      667      +11     
===========================================
+ Hits          1388     1411      +23     
+ Misses         937      925      -12     
+ Partials        68       65       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants