Skip to content

Commit 465674f

Browse files
committed
fixes #50, deploy 0.1.2
1 parent 533dde1 commit 465674f

File tree

8 files changed

+20
-21
lines changed

8 files changed

+20
-21
lines changed

Diff for: commands.py

+16-19
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
}
3737

3838
class OpenshiftOptionParser(OptionParser):
39-
def error(self, msg):
40-
pass
39+
def error(self, msg):
40+
pass
4141

4242
def execute(**kargs):
4343
command = kargs.get("command")
@@ -95,7 +95,7 @@ def execute(**kargs):
9595
check_windows()
9696

9797
if command == "hello": print "~ Hello from openshift module"
98-
if command == "test": openshift_test(app, env, options)
98+
if command == "test": openshift_test(args, app, env, options)
9999

100100
if command == "chk": openshift_check(app, options)
101101
if command == "fetch": openshift_fetch(args, app, env, options)
@@ -107,24 +107,23 @@ def execute(**kargs):
107107

108108
# This will be executed before any command (new, run...)
109109
def before(**kargs):
110-
command = kargs.get("command")
111-
app = kargs.get("app")
112-
args = kargs.get("args")
113-
env = kargs.get("env")
110+
command = kargs.get("command")
111+
app = kargs.get("app")
112+
args = kargs.get("args")
113+
env = kargs.get("env")
114114

115115
# This will be executed after any command (new, run...)
116116
def after(**kargs):
117-
command = kargs.get("command")
118-
app = kargs.get("app")
119-
args = kargs.get("args")
120-
env = kargs.get("env")
117+
command = kargs.get("command")
118+
app = kargs.get("app")
119+
args = kargs.get("args")
120+
env = kargs.get("env")
121121

122-
if command == "new":
123-
pass
122+
if command == "new":
123+
pass
124124

125-
def openshift_test(app, env, options):
125+
def openshift_test(args, app, env, options):
126126
print "testing 1,2,3"
127-
check_app(app, options)
128127

129128
def openshift_fetch(args, app, env, options):
130129

@@ -171,8 +170,6 @@ def openshift_fetch(args, app, env, options):
171170
def openshift_deploy(args, app, env, options, openshift_app=None):
172171
start = time.time()
173172

174-
options.app = check_appname(options.app)
175-
176173
if openshift_app == None: openshift_app = check_app(app, options) # check remote repo
177174
if openshift_app == None: error_message("ERROR - '%s' application not found at openshift" % options.app)
178175

@@ -206,7 +203,7 @@ def openshift_deploy(args, app, env, options, openshift_app=None):
206203

207204
start_war = time.time()
208205

209-
patched_war.package_as_war(app, env, war_path, war_zip_path=None, war_exclusion_list=['deployments'])
206+
patched_war.package_as_war(app, env, war_path, war_zip_path=None, war_exclusion_list=[deploy_folder])
210207

211208
if not os.path.exists(war_path):
212209
error_message("ERROR - '%s' exploded war folder could not be created" % war_path)
@@ -520,7 +517,7 @@ def create_app(app, options, check_app = False):
520517

521518
start = time.time()
522519

523-
create_cmd = ["rhc-create-app", "--type", 'jbossas-7.0']
520+
create_cmd = ["rhc-create-app", "--type", 'jbossas-7']
524521

525522
if options.debug == True: create_cmd.append("-d")
526523

Diff for: commands.pyc

-39 Bytes
Binary file not shown.

Diff for: conf/dependencies.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
self: play -> openshift 0.1.1
1+
self: play -> openshift 0.1.2
22

33
require:
44
- play
1.49 MB
Binary file not shown.

Diff for: documentation/manual/home.textile

+3
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,9 @@ In the current version of the module, Windows os is not supported. This is becau
150150

151151
h2. History
152152

153+
* Version 0.1.2 - Mar 07, 2012
154+
** Updated module to use new cartridge name (changed from jboss-7.0 to jboss-7)
155+
153156
* Version 0.1.1 - Mar 06, 2012
154157
** Fixed error with applications with upper case characters in it's name
155158
** Avoid contacting openshift when creating app

Diff for: lib/play-openshift.jar

0 Bytes
Binary file not shown.

Diff for: patched_war.py

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import shutil
66
import zipfile
77

8-
98
#patched play war command
109
def package_as_war(app, env, war_path, war_zip_path, war_exclusion_list = None):
1110
if war_exclusion_list is None:

Diff for: patched_war.pyc

0 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)