Skip to content

Commit 09b3a57

Browse files
committedFeb 2, 2024
Drop Debug fields
These fields were redundant. Crashing pods can be debugged via oc debug. Implements: OSPRH-4290
1 parent 8bf07ce commit 09b3a57

File tree

5 files changed

+0
-53
lines changed

5 files changed

+0
-53
lines changed
 

Diff for: ‎README.md

-4
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,6 @@ enabled: true
7474
template:
7575
containerImage: ""
7676
customServiceConfig: SESSION_TIMEOUT = 3600
77-
debug:
78-
service: false
7977
preserveJobs: false
8078
replicas: 1
8179
resources: {}
@@ -103,8 +101,6 @@ enabled: true
103101
template:
104102
containerImage: ""
105103
customServiceConfig: SESSION_TIMEOUT = 3600
106-
debug:
107-
service: false
108104
preserveJobs: false
109105
replicas: 1
110106
resources: {}

Diff for: ‎api/bases/horizon.openstack.org_horizons.yaml

-10
Original file line numberDiff line numberDiff line change
@@ -55,16 +55,6 @@ spec:
5555
added to to /etc/openstack-dashboard/local_settings.d directory
5656
as 9999_custom_settings.py file.
5757
type: string
58-
debug:
59-
description: Debug - enable debug for different deploy stages. If
60-
an init container is used, it runs and the actual action pod gets
61-
started with sleep infinity
62-
properties:
63-
service:
64-
default: false
65-
description: Service enable debug
66-
type: boolean
67-
type: object
6858
defaultConfigOverwrite:
6959
additionalProperties:
7060
type: string

Diff for: ‎api/v1beta1/horizon_types.go

-13
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,6 @@ type HorizonSpec struct {
5454
// NodeSelector to target subset of worker nodes running this service
5555
NodeSelector map[string]string `json:"nodeSelector,omitempty"`
5656

57-
// +kubebuilder:validation:Optional
58-
// Debug - enable debug for different deploy stages. If an init container is used, it runs and the
59-
// actual action pod gets started with sleep infinity
60-
Debug HorizonDebug `json:"debug,omitempty"`
61-
6257
// +kubebuilder:validation:Optional
6358
// +kubebuilder:default=false
6459
// PreserveJobs - do not delete jobs after they finished e.g. to check logs
@@ -103,14 +98,6 @@ type HorizionOverrideSpec struct {
10398
Service *service.RoutedOverrideSpec `json:"service,omitempty"`
10499
}
105100

106-
// HorizonDebug can be used to enable debug in the Horizon service
107-
type HorizonDebug struct {
108-
// +kubebuilder:validation:Optional
109-
// +kubebuilder:default=false
110-
// Service enable debug
111-
Service bool `json:"service"`
112-
}
113-
114101
// HorizonStatus defines the observed state of Horizon
115102
type HorizonStatus struct {
116103
// ReadyCount of Horizon instances

Diff for: ‎api/v1beta1/zz_generated.deepcopy.go

-16
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎config/crd/bases/horizon.openstack.org_horizons.yaml

-10
Original file line numberDiff line numberDiff line change
@@ -55,16 +55,6 @@ spec:
5555
added to to /etc/openstack-dashboard/local_settings.d directory
5656
as 9999_custom_settings.py file.
5757
type: string
58-
debug:
59-
description: Debug - enable debug for different deploy stages. If
60-
an init container is used, it runs and the actual action pod gets
61-
started with sleep infinity
62-
properties:
63-
service:
64-
default: false
65-
description: Service enable debug
66-
type: boolean
67-
type: object
6858
defaultConfigOverwrite:
6959
additionalProperties:
7060
type: string

0 commit comments

Comments
 (0)
Please sign in to comment.